Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firtool-resolver to 1.3.0 #3719

Merged
merged 1 commit into from Jan 9, 2024
Merged

Bump firtool-resolver to 1.3.0 #3719

merged 1 commit into from Jan 9, 2024

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jan 9, 2024

This would be an API modification but no Chisel has yet been released using firtool-resolver

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Dependency update

Desired Merge Strategy

  • Squash

Release Notes

To override which firtool is used by Chisel, users can set environment variable CHISEL_FIRTOOL_PATH.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.5.x, 3.6.x, or 5.x depending on impact, API modification or big change: 6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

To override which firtool is used by Chisel, users should now set
environment variable CHISEL_FIRTOOL_PATH (rather than the old
FIRTOOL_PATH).
@jackkoenig jackkoenig added the Dependency Update Updates a dependency, will be included in release notes label Jan 9, 2024
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackkoenig jackkoenig merged commit 8f147a3 into main Jan 9, 2024
17 checks passed
@jackkoenig jackkoenig deleted the bump-firtool-resolver branch January 9, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency Update Updates a dependency, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants