Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #3785

Merged
merged 1 commit into from Jan 30, 2024
Merged

Update CONTRIBUTING.md #3785

merged 1 commit into from Jan 30, 2024

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Jan 30, 2024

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • [N/A] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Documentation or website-related

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Update CONTRIBUTING instructions to clarify backport process and branch to target.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mwachs5 mwachs5 added the Documentation Only changing documentation label Jan 30, 2024
@mwachs5 mwachs5 added this to the 3.6.x milestone Jan 30, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) January 30, 2024 17:21
@jackkoenig jackkoenig merged commit d8991c5 into main Jan 30, 2024
17 checks passed
@jackkoenig jackkoenig deleted the mwachs5-patch-4 branch January 30, 2024 17:33
@mergify mergify bot added the Backported This PR has been backported label Jan 30, 2024
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit d8991c5)
@mergify mergify bot mentioned this pull request Jan 30, 2024
11 tasks
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit d8991c5)
mergify bot pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit d8991c5)
chiselbot pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit d8991c5)

Co-authored-by: Megan Wachs <megan@sifive.com>
chiselbot pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit d8991c5)

Co-authored-by: Megan Wachs <megan@sifive.com>
chiselbot pushed a commit that referenced this pull request Jan 30, 2024
(cherry picked from commit d8991c5)

Co-authored-by: Megan Wachs <megan@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Documentation Only changing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants