Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyncReadMem: read(addr) problem inside ShiftRegisterMem #2879

Closed
milovanovic opened this issue Dec 9, 2022 · 2 comments
Closed

SyncReadMem: read(addr) problem inside ShiftRegisterMem #2879

milovanovic opened this issue Dec 9, 2022 · 2 comments

Comments

@milovanovic
Copy link
Contributor

milovanovic commented Dec 9, 2022 •
edited
Loading

Type of issue: Bug Report

I believe that the commit broke some edge cases of ShiftRegisterMem. A detailed demonstration of this bug can be found here.
This was referenced Dec 13, 2022
Open
Merged
@jerryz123
Copy link
Contributor

I have not looked too closely, but I am inclined to believe that this is actually a bug in the implementation of ShiftRegisterMem. It should not rely on the undefined read-data of a SyncReadMem when the read-enable is low.

@milovanovic
Copy link
Contributor Author

You were right. The problem was indeed inside the ShiftRegisterMem. It should be fixed now, so this issue can be closed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sequencer @milovanovic @jerryz123