Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit EOF to top-level parser rule (bp #1217) #1250

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Add explicit EOF to top-level parser rule (bp #1217) #1250

merged 2 commits into from
Nov 22, 2019

Commits on Nov 22, 2019

  1. Add explicit EOF to top-level parser rule (#1217) 

    * Fixes #1154
* Tests that #1154 example produces SyntaxErrorsException
* Generally helps catch trailing syntax errors
* Performance-neutral relative to previous grammar
* Recommended by antlr4 devs, can help performance in some cases
* See antlr/antlr4#1540

(cherry picked from commit 8f108c1)
    @albert-magyar
    albert-magyar authored and mergify-bot committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    8af7bce View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.2.x' into mergify/bp/1.2.x/pr-1217

    @azidar
    azidar committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    48bf349 View commit details
    Browse the repository at this point in the history