This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 176
No FIRRTL parsing error on malformed input #1154
Comments
albert-magyar
added a commit
that referenced
this issue
Oct 29, 2019
* Fixes #1154 * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540
albert-magyar
added a commit
that referenced
this issue
Oct 29, 2019
* Fixes #1154 * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540
albert-magyar
added a commit
that referenced
this issue
Oct 29, 2019
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540
mergify bot
pushed a commit
that referenced
this issue
Nov 4, 2019
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540
mergify bot
pushed a commit
that referenced
this issue
Nov 22, 2019
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540 (cherry picked from commit 8f108c1)
mergify bot
added a commit
that referenced
this issue
Nov 22, 2019
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540 (cherry picked from commit 8f108c1)
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The following malformed FIRRTL snippet parses just fine, but leads to a very unintuitive error later on. Here, a user forgets to indent a line in a module. This seems to kill parsing and you wind up with a likely downstream error of no top module being found.
Type of issue: bug report
If the current behavior is a bug, please provide the steps to reproduce the problem:
See example above.
master
What is the use case for changing the behavior?
Impact: no functional change
Development Phase: request
The text was updated successfully, but these errors were encountered: