Add explicit EOF to top-level parser rule #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
albert-magyar
commented
Oct 29, 2019
albert-magyar
commented
- Fixes No FIRRTL parsing error on malformed input #1154
- Generally helps catch trailing syntax errors
- Performance-neutral relative to previous grammar
- Recommended by antlr4 devs, can help performance in some cases
- See antlr4 issue
albert-magyar
force-pushed
the
antlr4-eof
branch
from
39010b7
to
59d07a7
Compare
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540
albert-magyar
force-pushed
the
antlr4-eof
branch
from
59d07a7
to
a23c679
Compare
|
I added a test case for the example from #1154 that @seldridge found. |
azidar
approved these changes
Nov 4, 2019
albert-magyar
added
the
Please Merge
|
@Mergifyio backport 1.2.x |
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2019
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540 (cherry picked from commit 8f108c1)
|
Command
Hey, we reacted but our real name is @Mergifyio |
mergify bot
added a commit
that referenced
this pull request
Nov 22, 2019
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540 (cherry picked from commit 8f108c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.