Multi protobuf module emission and consumption #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
Sep 1, 2021
Co-authored-by: Jack Koenig <koenig@sifive.com>
mwachs5
reviewed
Sep 2, 2021
mwachs5
reviewed
Sep 2, 2021
| new ShellOption[String]( | ||
| longOption = "input-directory", | ||
| toAnnotationSeq = a => Seq(FirrtlDirectoryAnnotation(a)), | ||
| helpText = "A directory of FIRRTL files", |
There was a problem hiding this comment.
can these be either .fir or .pb files? A mixture?
There was a problem hiding this comment.
We should figure that out. I think to start we should make it be only .fir or only .pb files. Note that -i actually doesn't care about file extensions, it just tries to deserialize as protobuf and if it fails it deserializes as .fir but I think it's okay to require correct file extensions here.
mwachs5
reviewed
Sep 2, 2021
jackkoenig
reviewed
Sep 3, 2021
Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig
approved these changes
Sep 8, 2021
Co-authored-by: Jack Koenig <koenig@sifive.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
* Add compiler option (`-p`) to emit individual module protobufs * Implement multi module combination when reading directory of protobufs Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 0c1ca58)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2021
* Multi protobuf module emission and consumption (#2344) * Add compiler option (`-p`) to emit individual module protobufs * Implement multi module combination when reading directory of protobufs Co-authored-by: Jack Koenig <koenig@sifive.com> (cherry picked from commit 0c1ca58) * Multi PB backport fixes (#2353) Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
Type of Improvement
API Impact
No API impact
Backend Code Generation Impact
Can change ordering of modules.
MultiInfos do not serialize properly because of placeholder code in the protobuf emitter.Desired Merge Strategy
Release Notes
Implement multiple protobuf emission and consumption in the FIRRTL compiler
-poption exports all modules into individual protobuf files, similar to-e.-Ioption takes a directory of FIRRTL files, deserializes them and combines them back into a single circuit. Currently supports only the protobuf files emitted by-pReviewer Checklist (only modified by reviewer)
Please Merge?