New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifying SRAMAnnotations for OM purposes #1944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
reviewed
May 13, 2019
jackkoenig
reviewed
May 13, 2019
jackkoenig
reviewed
May 13, 2019
jackkoenig
requested changes
May 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the style nits really matter, but we should considering making the idhash
a Long
debs-sifive
force-pushed
the
anno-descsram
branch
from
May 14, 2019 17:57
842a0f9
to
e3cd74d
Compare
debs-sifive
force-pushed
the
anno-descsram
branch
from
May 14, 2019 18:40
e3cd74d
to
6453534
Compare
jackkoenig
reviewed
May 15, 2019
jackkoenig
approved these changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jackkoenig
added a commit
that referenced
this pull request
Jun 4, 2019
This reverts commit 0efc0aa.
jackkoenig
added a commit
that referenced
this pull request
Jun 5, 2019
Revert "Modifying SRAMAnnotations for OM purposes (#1944)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
SRAMAnnotation
s have the target typeReferenceTarget
to allow for unique path generationDescribedSRAM
s generate a unique ID that can be correlated to the OM@derekpappas @jackkoenig