Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying SRAMAnnotations for OM purposes #1944

Merged
merged 7 commits into from May 15, 2019

Conversation

debs-sifive
Copy link
Contributor

Type of change: other enhancement

Impact: API modification

Development Phase: implementation

Release Notes

  • SRAMAnnotations have the target type ReferenceTarget to allow for unique path generation
  • DescribedSRAMs generate a unique ID that can be correlated to the OM

@derekpappas @jackkoenig

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the style nits really matter, but we should considering making the idhash a Long

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackkoenig jackkoenig merged commit 0efc0aa into chipsalliance:master May 15, 2019
jackkoenig added a commit that referenced this pull request Jun 4, 2019
jackkoenig added a commit that referenced this pull request Jun 5, 2019
Revert "Modifying SRAMAnnotations for OM purposes (#1944)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants