Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple waiver files #293

Closed
imphil opened this issue May 7, 2020 · 0 comments
Closed

Support multiple waiver files #293

imphil opened this issue May 7, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request style-linter Verilog style-linter issues

Comments

@imphil
Copy link
Contributor

imphil commented May 7, 2020

With the PR #245 (issue #105) one waiver file per Verible run is now supported by passing the name of a waiver file to the --waivers_file argument. For our use cases it would be beneficial to be able to specify multiple waiver files.

For example on OpenTitan, we have one waiver file per IP block to keep them separated from each other. IPs which depend on each other will then use the combined set of waivers (and RTL files, etc.).

This feature is supported by Ascent Lint and Verilator Lint, and it would be great to have the same functionality in Verible.

Would it be possible to allow multiple --waivers_file options to enable that? In existing tools, the waivers are simply concatenated together, nothing fancy beyond that happens.

@fangism fangism added enhancement New feature or request style-linter Verilog style-linter issues labels May 19, 2020
@fangism fangism added this to waiver system in SV style linter May 19, 2020
@tgorochowik tgorochowik self-assigned this May 21, 2020
tgorochowik added a commit to antmicro/verible that referenced this issue May 21, 2020
Fixes: chipsalliance#293

Signed-off-by: Tomasz Gorochowik <tgorochowik@antmicro.com>
tgorochowik added a commit to antmicro/verible that referenced this issue May 26, 2020
Fixes: chipsalliance#293

Signed-off-by: Tomasz Gorochowik <tgorochowik@antmicro.com>
imphil added a commit to imphil/edalize that referenced this issue Jul 2, 2020
Since chipsalliance/verible#293 Verible lint supports
multiple rules files; add support for that to edalize.

I didn't add any version detection for Verible since we're currently
assuming `master` of Verible for edalize, as long as Verible hasn't done
a stable release yet.

Fixes olofk#153
imphil added a commit to imphil/edalize that referenced this issue Jul 2, 2020
Since chipsalliance/verible#293 Verible lint supports
(multiple) waiver files; add support for that to edalize.

I didn't add any version detection for Verible since we're currently
assuming `master` of Verible for edalize, as long as Verible hasn't done
a stable release yet.

Fixes olofk#153
imphil added a commit to olofk/edalize that referenced this issue Jul 14, 2020
Since chipsalliance/verible#293 Verible lint supports
(multiple) waiver files; add support for that to edalize.

I didn't add any version detection for Verible since we're currently
assuming `master` of Verible for edalize, as long as Verible hasn't done
a stable release yet.

Fixes #153
nikhiljha pushed a commit to nikhiljha/verible that referenced this issue Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request style-linter Verilog style-linter issues
Projects
SV style linter
waiver system
Development

Successfully merging a pull request may close this issue.

3 participants