Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[line breaks, wraps] Multiline string initializer #41

Closed
msfschaffner opened this issue Nov 26, 2019 · 3 comments · Fixed by #834
Closed

[line breaks, wraps] Multiline string initializer #41

msfschaffner opened this issue Nov 26, 2019 · 3 comments · Fixed by #834
Assignees
Labels
formatter Verilog code formatter issues opentitan

Comments

@msfschaffner
Copy link

should:

  task body();
    string seq_names[] = {"uart_sanity_vseq",
                          "uart_tx_rx_vseq",
                          "uart_fifo_full_vseq",
                          "uart_fifo_overflow_vseq",
                          "uart_fifo_reset_vseq",
                          "uart_common_vseq", // for intr_test
                          "uart_intr_vseq",
                          "uart_noise_filter_vseq",
                          "uart_rx_start_bit_filter_vseq",
                          "uart_rx_parity_err_vseq",
                          "uart_tx_ovrd_vseq",
                          "uart_perf_vseq",
                          "uart_loopback_vseq"};
  endtask : body

is:

  task body();
    string
        seq_names[] = {"uart_sanity_vseq", "uart_tx_rx_vseq", "uart_fifo_full_vseq",
                       "uart_fifo_overflow_vseq", "uart_fifo_reset_vseq", "uart_common_vseq",
        // for intr_test
        "uart_intr_vseq", "uart_noise_filter_vseq", "uart_rx_start_bit_filter_vseq",
            "uart_rx_parity_err_vseq", "uart_tx_ovrd_vseq", "uart_perf_vseq", "uart_loopback_vseq"};
  endtask : body
@msfschaffner
Copy link
Author

This is related to #32 and #33.

@msfschaffner
Copy link
Author

b/145168492

@msfschaffner
Copy link
Author

Here is another related instance with an initializer list.

should:

  // this defines a random permutation
  localparam int unsigned perm[32] = '{
    4, 11, 25, 3,   //
    15, 16, 1, 10,  //
    2, 22, 7, 0,    //
    23, 28, 30, 19, //
    27, 12, 24, 26, //
    14, 21, 18, 5,  //
    13, 8, 29, 31,  //
    20, 6, 9, 17
  };

is:

  // comment
  localparam int unsigned perm[32] = '{4, 11, 25, 3,  //
  15, 16, 1, 10,  //
  2, 22, 7, 0,  //
  23, 28, 30, 19,  //
  27, 12, 24, 26,  //
  14, 21, 18, 5,  //
  13, 8, 29, 31,  //
  20, 6, 9, 17};

@fangism fangism added the formatter Verilog code formatter issues label Nov 26, 2019
@fangism fangism added this to indentation in SV formatter Nov 26, 2019
@tgorochowik tgorochowik self-assigned this Dec 5, 2019
@tgorochowik tgorochowik removed their assignment Feb 3, 2020
@mglb mglb self-assigned this Apr 12, 2021
@ghost ghost added the opentitan label Jun 18, 2021
nikhiljha pushed a commit to nikhiljha/verible that referenced this issue Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Verilog code formatter issues opentitan
Projects
SV formatter
indentation
Development

Successfully merging a pull request may close this issue.

4 participants