Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typed-path versions for current_exe and temp_dir, including UTF8 variants #24

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

simongoricar
Copy link
Contributor

Hello! I'm currently migrating to typed-path in my project and noticed that there were two path-related functions from std::env that I could not find in the utilities module.

This pull request adds the following functions under typed_path::utils:

  • current_exe, which corresponds to std::env::current_exe,
  • utf8_current_exe, which is a UTF8 version of current_exe,
  • temp_dir, which corresponds to std::env::temp_dir, and
  • utf8_temp_dir, which is a UTF8 version of temp_dir.

@chipsenkbeil
Copy link
Owner

Awesome! Looks like there's some linter failures related to doc comments. On my phone, so can't quite tell what the reason is right now.

@simongoricar
Copy link
Contributor Author

Seems unrelated - looks like it doesn't like the fn main in README.md doctests (the failure is error: needless fn main in doctest six times).

@chipsenkbeil
Copy link
Owner

Ah, I guess you're right! Most likely, this is some addition to the linter that happened since the last commit to the project. Let's merge this and I'll take a look at correcting the rest.

@chipsenkbeil chipsenkbeil merged commit cc75416 into chipsenkbeil:main Jun 15, 2024
15 of 17 checks passed
@chipsenkbeil
Copy link
Owner

@simongoricar published as 0.9.0. Thanks for the contribution!

@simongoricar
Copy link
Contributor Author

A pleasure, thanks for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants