Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support search. #49

Closed
razonyang opened this issue Sep 26, 2020 · 23 comments
Closed

Feature request: support search. #49

razonyang opened this issue Sep 26, 2020 · 23 comments
Assignees
Labels
enhancement New feature or request fixed Issue resolved
Milestone

Comments

@razonyang
Copy link
Contributor

No description provided.

@onweru onweru added this to the 2.0 milestone Sep 27, 2020
@chipzoller
Copy link
Owner

chipzoller commented Sep 27, 2020

Search is already planned for the 2.0 release.

@chipzoller chipzoller reopened this Sep 27, 2020
@chipzoller chipzoller added the enhancement New feature or request label Oct 1, 2020
@razonyang
Copy link
Contributor Author

Is somebody working on this? If not, maybe I can help.

@chipzoller
Copy link
Owner

chipzoller commented Oct 9, 2020

Yes, we will be adopting a search implementation by @onweru in his Compose theme. If you'd like to supply fixes or feedback on the search function, it would be best to use this issue so it can be tracked in one spot.

@vietanhdev
Copy link

vietanhdev commented Oct 31, 2020

I implemented my search page using this tutorial. Hope this will help.

@chipzoller
Copy link
Owner

Nice work there, and nice blog!

@razonyang
Copy link
Contributor Author

razonyang commented Nov 4, 2020

@vietanhdev Yes, that tutorial was really useful. I also implemented search feature for my theme.

I suggest using Fuse.js instead of Lunr.js in this theme, since Lunr doesn't work well in a non-English language.

@sosiristseng
Copy link
Contributor

FYI, there is a partial theme implementation of Fuse.js search: https://github.com/kaushalmodi/hugo-search-fuse-js

The search page is hosted on Hugo-bare-min theme: https://hugo-bare-min.netlify.app/search/

@onweru
Copy link
Collaborator

onweru commented Nov 23, 2020

We're working on it, so far we have got this far. The current implementation is using Fuse.js as advised earlier in this thread.

@sosiristseng
Copy link
Contributor

Wow! The search bar is pretty smooth and polished. And the compose theme also looks very nice for documentation.

I appreciate your hard work and look forward to seeing this function added to clarity.

@onweru
Copy link
Collaborator

onweru commented Nov 23, 2020

@sosiristseng, we'll get there. Thank you.

@chipzoller
Copy link
Owner

For those watching this issue, there have been some significant advancements made in the search functionality that Clarity will eventually adopt, including some functionality that isn't found many other places. Stay tuned.

@Fingel
Copy link

Fingel commented Dec 17, 2020

Just wanted to say, amazing theme. I was just about to start implementing search with it and found this. Now I think I'll just be patient. Thanks! Please post here if you need any help.

@andyjenkins1
Copy link

All just checking in to see what the latest update was on Search?, Noticed the last update was Dec, so just checking to see if any further progress?. Great theme and excellent work!.

@chipzoller
Copy link
Owner

Search is still planned for Clarity v2 which should kickoff in the next couple of months. If you'd like to get a feel for what we're planning on bringing to Clarity, check out @onweru custom search function here.

@onweru onweru self-assigned this Apr 2, 2021
@andyjenkins1
Copy link

Thats, great, appreciate the update!.

@branchus
Copy link

Perfect, I came here to suggest this and saw this has been planned, Thank you!

@joesan
Copy link

joesan commented Dec 12, 2021

I think this is another missing bit in this awesome theme. Any plans as to when this could go live?

@ainy0293
Copy link

I would also like to ask, is there any time plan for the 2.0 version of the search function? thinks

@LITUATUI
Copy link

Any news?

@onweru
Copy link
Collaborator

onweru commented Mar 22, 2022

@LITUATUI, as soon as next monday.

onweru added a commit that referenced this issue Mar 24, 2022
Signed-off-by: weru <fromweru@gmail.com>
onweru added a commit that referenced this issue Mar 24, 2022
Signed-off-by: weru <fromweru@gmail.com>
onweru added a commit that referenced this issue Mar 24, 2022
Signed-off-by: weru <fromweru@gmail.com>
onweru added a commit that referenced this issue Mar 24, 2022
Signed-off-by: weru <fromweru@gmail.com>
@onweru onweru added the fixed Issue resolved label Mar 24, 2022
onweru added a commit that referenced this issue Mar 24, 2022
Signed-off-by: weru <fromweru@gmail.com>
@onweru
Copy link
Collaborator

onweru commented Mar 24, 2022

@chipzoller, I think the first implementation of search on this theme is in. Please review it when you can.

@chipzoller
Copy link
Owner

Will do ASAP

onweru added a commit that referenced this issue Mar 24, 2022
Signed-off-by: weru <fromweru@gmail.com>
@chipzoller
Copy link
Owner

Since an initial implementation of search by @onweru is now available, I'm closing this issue. We will work towards polishing the search feature, and for any bugs or requests around search please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Issue resolved
Projects
None yet
Development

No branches or pull requests