Add event for didHide #29
Conversation
ToolTip.ios.js
Outdated
| }; | ||
| }, | ||
|
|
||
| showMenu: function() { | ||
| ToolTipMenu.show(findNodeHandle(this.refs.toolTipText), this.getOptionTexts(), this.props.arrowDirection); | ||
| this.props.onShow(); |
There was a problem hiding this comment.
this is superficial and can live in userland
There was a problem hiding this comment.
This is true for programmatically displaying the tooltip but there's no way to attach an event when you use show it using the longPress prop. I think there should be e.g. if you want to change the style when the tooltip is displayed.
There was a problem hiding this comment.
showMenu here is only used when programmatically displaying the tooltip. about ur usecase:
y can't you do something like this:
handleLongPress() {
showMenu();
this.setState({ style: { ...} })
}
that's just an example. I'm trying to understand the use case better.
There was a problem hiding this comment.
That's because the either onLongPress or either onPress is overwritten and there is no way to opt-out. So it can't be used like a controlled component. Hope this helps.
ToolTip.ios.js
Outdated
| arrowDirection: 'down' | ||
| arrowDirection: 'down', | ||
| onHide: () => true, | ||
| onShow: () => true |
ToolTip.ios.js
Outdated
| @@ -24,15 +24,19 @@ var propTypes = { | |||
| var ViewClass = React.createClass({ | |||
| getDefaultProps: function() { | |||
| return { | |||
| arrowDirection: 'down' | |||
| arrowDirection: 'down', | |||
| onHide: () => true, | |||
ToolTip.ios.js
Outdated
| }, | ||
| hideMenu: function() { | ||
| ToolTipMenu.hide(); | ||
| this.props.onHide(); |
There was a problem hiding this comment.
just check if onHide is available
There was a problem hiding this comment.
wondering if this would create a cycle when invoking hideMenu programmatically? something like ->
hideMenu() => tooltipMenu.hide => onHide => onBlur will be called => hideMenu ....
| @@ -1,6 +1,7 @@ | |||
| #import <UIKit/UIKit.h> | |||
| #import <React/RCTBridgeModule.h> | |||
|
|
|||
|
|
|||
|
@enahum unfortunately i'm not using/maintaining this module anymore. guessing @jrichardlai is also not using it anymore. If this is something you care about and use i'm happy to add you as a collaborator. Let me know if that works for you. |
|
@chirag04 actually we use this module in our production app https://github.com/mattermost/mattermost-mobile and I do have a fork of this project. Let me bring this to discussion in our organization and I’ll get back to you. |
|
Second for use in production. I'm using it in http://www.wonderswipe.com/ |
|
To be clear, I use this module in production for lrnapp.com. Just that i don't maintain the app and this module anymore. @fungilation Looks cool. |
|
@chirag04 we discuss this in our org and we would like to collaborate as an org perhaps you could join our mattermost pre-release server and talk about it some more? Server: https://pre-release.mattermost.com Feel free to ping me there if you are interested |
|
will submit another PR for this one. |
This PR introduces an event handler for when the tooltip hides