Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failures after Scryfall API changes #56

Closed
furgin opened this issue Jan 15, 2023 · 0 comments · Fixed by #57
Closed

Test failures after Scryfall API changes #56

furgin opened this issue Jan 15, 2023 · 0 comments · Fixed by #57

Comments

@furgin
Copy link
Contributor

furgin commented Jan 15, 2023

Tests for getImageURI - Looks like the host name for the image URLs have changed.
BulkData compressed_size - This field appears to have changed name to 'size'
furgin added a commit to furgin/scryfall-sdk that referenced this issue Jan 15, 2023
@furgin
Fixes ChiriVulpes#56
5ac4760 
* Updated card image uri
* Changed compressed_size field to size
@furgin furgin mentioned this issue Jan 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests, add svg_uri field, and fix CollectorNumber type furgin/scryfall-sdk
1 participant
@furgin