Replace PATHSolver with odow/PATH.jl #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PATH.jl to MOI.Complements
Update build.jl
* BuMP MOI * BuMP MOI 0.9.11
* Add missing libgfortran * Bump travis
* Add MOI.Silent attribute * Improve coverage
Ferris pull, then updating pathlib
* Move to binaries hosted at wisc.edu * Fix Appveyor * Add 1.4 to Windows CI * Add LUSOL with test * Fix LUSOL on 1.4 * [ci skip] add to README * Disable LUSOL for now * Reenable LUSOL tests * Remove @c_api * Improve coverage
* Add transmcp as MOI example * GC.@preserve the IOBuffer * Dedent GC preserve
* Update Project.toml * Update Project.toml
* Check mutability of stdout * Update C_API.jl
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 96.84% 94.62% -2.22%
==========================================
Files 1 3 +2
Lines 95 242 +147
==========================================
+ Hits 92 229 +137
- Misses 3 13 +10
Continue to review full report at Codecov.
|
|
@chkwon ready to merge this when you are, or you could add me as a collaborator? |
This was referenced Jan 26, 2021
|
@odow Do you think transferring the ownership to you would help you manage? I'd do it if you like. |
|
Happy to leave it here for now. We can revisit if it becomes a problem. Another option is to add it to jump-dev if we want to add some complementarity examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to register PATH.jl as a new package. However, it was pointed out that "PATH" is a pretty common name to add the the registry, and PATHSolver already exists, so we should just make a complete overhaul of PATHSolver.
Closing all open issues as irrelevant. People can re-open if they encounter bugs in the new package.
Closes #4
Closes #15
Closes #18
Closes #38