Axes don't update when gamepad reports all axes values near zero

[chlorate]

Axis values are only updated if the gamepad reports at least one axis with a non-zero value.

The code in question:

input-display/src/controller/controller.ts

Lines 179 to 181 in d1f0cba

	// Ignore if all axes read zero which means the gamepad hasn't been
	// fully activated yet.
	const active = gamepad.axes.some((value) => value !== 0);

I assumed all zero axes meant the gamepad was not fully connected and would never be a normal operating state. This is the case with the Wii Classic Controller Pro where it will send all zeros while it's connecting. The purpose of ignoring this state was to avoid setting axis neutral values to zero when initializing for the first time. (The neutral values are normally slightly off from zero.)

It turns out the CCP actually sends several different values outside its normal range while it's connecting. So this doesn't avoid the issue with initializing neutral values after all.

For other controllers, all zeros can be a valid neutral state and this can cause the display to not update to show analog sticks as neutral.

The code should be changed to update axes in all cases.

https://twitter.com/AceOfArrows/status/1086626032956903424

(What's puzzling about this is the check is value !== 0 and this controller isn't updating despite reporting a non-exactly-zero value.)

[chlorate]

Confirmed working. Gamepad tester site must have a rounding error.