New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review] Insert citation to NumPy in Paper #62

Closed

fwitte opened this issue Oct 8, 2022 · 1 comment

fwitte commented Oct 8, 2022

Hi @jranalli and @chmarti1,

since the package depends on NumPy, you could insert a citation here, see: https://numpy.org/citing-numpy/.

PYroMat/joss2022/paper.md

Line 101 in ffe8f45

    
           Using the Numpy library for compiled back-end numerical efficiency, `PYroMat` has been designed to efficiently handle large arrays of input data.  The iterative back-end operations on hundred-thousand-element arrays consistently execute in a few seconds on a single core of an old laptop.

jranalli added a commit that referenced this issue


          Update based on comments in #62 and #60

1a17987

Collaborator

jranalli commented Oct 10, 2022

Added reference in recent commit 1a17987

jranalli closed this as completed

fwitte mentioned this issue

[REVIEW]: PYroMat: A Python package for thermodynamic properties openjournals/joss-reviews#4757

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment