-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for gulp 4.0, also changed argument order #19
Conversation
* new argument order: gulp.task([name, help, taskOptions, ] fn)
Thanks for this PR! If you find time to clean this up, I'll merge it as soon as gulp 4.0 is officially released |
Also wanted to note that 4.0 comes with a task list gulp --tasks-simple While not providing descriptions for tasks currently there have been discussions on it and it looks like they'll be made available in some form, definitely worth keeping an eye on. Hopefully it'll be something that's easy to tap into so you can still use aliases and hidden members but as of now it's still not implemented. |
Ended up having to roll something out for this functionality at work. When 4.0 comes out feel free to steal whatever you need from it, I may be able to jump back on to help once it is released but it depends on the work schedule. Unfortunately it was faster for me just to rewrite the help module for 4.0 so it's not a pull request In case I can get back to helping support 4.0 would you be trying to maintain backwards compatibility in the task definitions so it can work across versions? the task API changes in 4.0 are fairly substantial. Published on npm for now if anybody needs a temporary solution, I'll unpublish it once gulp 4 is out and gulp-help is ready to go with it |
@thotjs cool, thanks for the input. I don't think maintaining backwards compatibility with gulp 3.x is necessary. Most gulp modules assume you're using the latest and greatest of everything. Plus, I'll be using proper semver on this package, so someone can just take a previous version that will work with gulp 3.x. If anyone disagrees with my comments above just speak up. |
@chmontgomery you could also do what gulp does and add a 4.0 branch. Then have PRS submitted to that for gulp4 fixes. That way people can target their package.json to use the 4.0 branch. |
Just created a |
Is this repo still needed with 4.0? We added a help command, curious to see where we still haven't met the needs of the community. |
@contra check out the I made the assumption you would not be interested in these kind of features in gulp core. If that's not the case, I'd be willing to make a PR to put these kind of features in gulp directly (perhaps under a |
@chmontgomery We added the |
Hi, this was a quick n dirty modification to make it work with gulp 4.0. I don't expect you to merge this in right away - it's just for review / inspiration.
I won't work on this the next 3 weeks (too busy), but it works already for my purposes :-)
Limitations so far: