Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createRemotelink: capitalize globalId properly #178

Merged
merged 1 commit into from
Dec 9, 2018

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Dec 6, 2018

@aik099
Copy link
Collaborator

aik099 commented Dec 6, 2018

Nice catch. Likely due wrongly specified global ID the created remote link has auto-generated ID, that can't be used to update that link later on.

Please also change CHANGELOG.md file.

@glensc
Copy link
Contributor Author

glensc commented Dec 9, 2018

updated.

and yes, with wrongly provided globalId it creates new link each time instead of updating existing one. that's why i needed a fix, as i update the link title in my project.

@aik099 aik099 merged commit 0e0fe0c into chobie:master Dec 9, 2018
@aik099
Copy link
Collaborator

aik099 commented Dec 9, 2018

Merging, thanks @glensc .

@glensc glensc deleted the patch-1 branch December 9, 2018 21:49
@glensc
Copy link
Contributor Author

glensc commented Feb 13, 2019

btw, jira itself is annoying, it leaves activity comment for each update even if the globalId is present and other payload is identical.

so, for my own solution, i might need to keep track of updated remote links locally or find a way to query existing remote links and update only non-matching ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants