feat: added codecov support and made coveralls optional #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann510
requested changes
Nov 2, 2020
| @@ -148,7 +148,7 @@ const Ui: FC = () => { | |||
| <Box marginBottom={1} /> | |||
|
|
|||
| <LabelValueInput | |||
| label="Coveralls token" | |||
| label="Coveralls token [optional]" | |||
| inputValue={coverallsToken} | |||
There was a problem hiding this comment.
You should add the Press enter to skip placeholder like the others.
Also, do we want to provide support setup for codecov in the CLI?
If so, let's create a new issue I guess.
There was a problem hiding this comment.
Alright lets create an issue for an additional optional command for codecov. I'll wrap up this once since I'm already here
1 task
yann510
approved these changes
Nov 3, 2020
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102