Upgrade all reuses overridden package parameters when useRememberedArgumentsForUpgrades feature is turned on #1443

dinfinity · 2017-11-06T13:35:18Z

What You Are Seeing?

I have a multitude of packages installed via chocolatey, a number of which I have set custom install directories for. Chocolatey regularly shows error messages that indicate that the overridden parameters for another package are used. For instance:

ERROR: Running ["C:\Users\Dual Infinity\AppData\Local\Temp\chocolatey\TotalCommander\9.10\INSTALL.exe" INSTALLDIR=C:\Frameworks\NodeJS] was not successful. Exit code was '1'. See log for possible error messages.
The upgrade of totalcommander was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\TotalCommander\tools\chocolateyInstall.ps1'.
 See log for details.

It seems to use the last overridden parameters encountered.

Addendum 2017-11-07:
The issue is usually resolved by running the upgrade all command multiple times. It does not seem random, but it does seem that if a package with custom parameters was installed successfully its parameters are not read and do not conflict in the subsequent run of upgrade all.

What is Expected?

Chocolatey should (obviously) not reuse package parameters for other packages.

How Did You Get This To Happen? (Steps to Reproduce)

In essence, this would entail setting custom install dirs for multiple packages and running chocolatey upgrade all.

Output Log

See zip:
dinfinity.chocolatey.log.2017-11-06.zip

I'm adding the following to the issue description:
"The issue is usually resolved by running the upgrade all command multiple times. It does not seem random, but it does seem that if a package with custom parameters was installed successfully its parameters are not read and do not conflict in the subsequent run of upgrade all."

ferventcoder · 2018-02-12T18:07:18Z

Without a repo, we'll need to bump this to vNext.

Vankog · 2018-03-07T21:23:05Z

As it turns out, this also happened to me:
http://disq.us/p/1qp8o56

VLC got "upgraded" from 64 to 32bit on upgrade all after reusing remembered arguments that forced the 32bit upgrade for notepadplusplus earlier.

ferventcoder · 2018-05-04T19:34:57Z

I'm wondering if packages getting upgraded as a result of being a dependency of another package are getting hit by this...

ferventcoder · 2018-05-04T19:35:57Z

Adding a partial adjustment for 0.10.11, but we'll need to see if it alleviates the bigger issue - I don't think it will until we isolate for each package.

There may be a condition somewhere when the config gets changed each time through for a package. Note this won't cover dependencies, they will likely get those arguments passed to them.

* stable: (version) 0.10.11 (doc) update release notes for 0.10.11 (GH-1540) Fix - AutoUninstaller can't find escaped quotes (GH-1543) Fix - log format error on install location with GUID (GH-1500) Fix - Wrap Write-Host if used in setup (GH-991) Install - Modify profile if file exists & empty (GH-1443) Set original config before loop (maint) add a note for GH-1548 (GH-1557) Upgrade 7z to 18.5

Ensure the config is reset to a known point with each package being run in an operation. Previously it was thought this was happening, but the way the reset occurred was actually changing the original configuration and the current. Ensure that is getting reset accordingly by doing the deep copy to set config each time through.

dinfinity · 2018-12-28T18:13:01Z

In my case this seems very very similar to what is reported here: #797

There are 2 packages (out of many) that I installed with -ia "INSTALLDIR=C:\aaa\bbb" (Vagrant and NodeJS) and some other packages (Total Commander, Mysql Workbench, Google Earth Pro) want to install into the NodeJS and Vagrant directories.

I see a fix has been added in 347f09f
I am hoping that will solve this very, very annoying issue.

This adds a extra parameter to the upgrade_run method, which is used to pass an action which resets the configuration in the function that calls upgrade_run. This fixes a bug when useRememberedArguments is enabled that causes arguments to be reused in the chocolateyInstall.ps1 when multiple packages are upgraded. It happens because OptionSet.parse() sets the configuration via the actions specified in the UpgradeCommand optionSet setup (and likewise in configuration builder as well). It only sets options that are saved, so if a later package does not have an option, it is not set, and the previous option is reused. This fixes the bug because it resets the configuration at the ChocolateyPackageService level, which is enough to reset the configuration for action that runs the PowerShell as well.

This updates the action used when handling package results during upgrade to reset the configuration class that is initially set. This is done as an alternative way other than updating the source runners themself with a breaking change to the interfaces. This fixes a bug when useRememberedArguments is enabled that causes arguments to be reused in the chocolateyInstall.ps1 when multiple packages are upgraded. It happens because OptionSet.parse() sets the configuration via the actions specified in the UpgradeCommand optionSet setup (and likewise in configuration builder as well). It only sets options that are saved, so if a later package does not have an option, it is not set, and the previous option is reused. This fixes the bug because it resets the configuration at the ChocolateyPackageService level, which is enaugh to reset the configuration for action that runs the PowerShell as well. Co-authored-by: TheCakeIsNaOH <TheCakeIsNaOH@gmail.com>

This commit adds two new methods to the Chocolatey Configuration class that will be used to create a backup of the current values inside the Config class, without these being able to be changed. Once requested and the backup exists, we are then able to reset the Config file without loosing the reference to the class. This was something that is needed, as we rely in several places that the reference is updatable throughout the entire Chocolatey CLI codebase. This also means we can not replace the reference to the Config file itself without loosing the ability to make use of remembered arguments when multiple packages requires these to be used.

This updates the action used when handling package results during upgrade to reset the configuration class that is initially set. This fixes a bug when useRememberedArguments is enabled that causes arguments to be reused in the chocolateyInstall.ps1 when multiple packages are upgraded. It happens because OptionSet.parse() sets the configuration via the actions specified in the UpgradeCommand optionSet setup (and likewise in configuration builder as well). It only sets options that are saved, so if a later package does not have an option, it is not set, and the previous option is reused. This fixes the bug because it resets the configuration at the ChocolateyPackageService level, which is enough to reset the configuration for action that runs the PowerShell as well. Co-authored-by: TheCakeIsNaOH <TheCakeIsNaOH@gmail.com>

This commit adds two new methods to the Chocolatey Configuration class that will be used to create a backup of the current values inside the Config class, without these being able to be changed. Once requested and the backup exists, we are then able to reset the Config file without loosing the reference to the class. This was something that is needed, as we rely in several places that the reference is updatable throughout the entire Chocolatey CLI codebase. This also means we can not replace the reference to the Config file itself without loosing the ability to make use of remembered arguments when multiple packages requires these to be used.

This updates the action used when handling package results during upgrade to reset the configuration class that is initially set. This fixes a bug when useRememberedArguments is enabled that causes arguments to be reused in the chocolateyInstall.ps1 when multiple packages are upgraded. It happens because OptionSet.parse() sets the configuration via the actions specified in the UpgradeCommand optionSet setup (and likewise in configuration builder as well). It only sets options that are saved, so if a later package does not have an option, it is not set, and the previous option is reused. This fixes the bug because it resets the configuration at the ChocolateyPackageService level, which is enough to reset the configuration for action that runs the PowerShell as well. Co-authored-by: TheCakeIsNaOH <TheCakeIsNaOH@gmail.com>

This commit adds two new methods to the Chocolatey Configuration class that will be used to create a backup of the current values inside the Config class, without these being able to be changed. Once requested and the backup exists, we are then able to reset the Config file without loosing the reference to the class. This was something that is needed, as we rely in several places that the reference is updatable throughout the entire Chocolatey CLI codebase. This also means we can not replace the reference to the Config file itself without loosing the ability to make use of remembered arguments when multiple packages requires these to be used.

This updates the action used when handling package results during upgrade to reset the configuration class that is initially set. This fixes a bug when useRememberedArguments is enabled that causes arguments to be reused in the chocolateyInstall.ps1 when multiple packages are upgraded. It happens because OptionSet.parse() sets the configuration via the actions specified in the UpgradeCommand optionSet setup (and likewise in configuration builder as well). It only sets options that are saved, so if a later package does not have an option, it is not set, and the previous option is reused. This fixes the bug because it resets the configuration at the ChocolateyPackageService level, which is enough to reset the configuration for action that runs the PowerShell as well. Co-authored-by: TheCakeIsNaOH <TheCakeIsNaOH@gmail.com>

This commit adds two new methods to the Chocolatey Configuration class that will be used to create a backup of the current values inside the Config class, without these being able to be changed. Once requested and the backup exists, we are then able to reset the Config file without loosing the reference to the class. This was something that is needed, as we rely in several places that the reference is updatable throughout the entire Chocolatey CLI codebase. This also means we can not replace the reference to the Config file itself without loosing the ability to make use of remembered arguments when multiple packages requires these to be used.

This updates the action used when handling package results during upgrade to reset the configuration class that is initially set. This fixes a bug when useRememberedArguments is enabled that causes arguments to be reused in the chocolateyInstall.ps1 when multiple packages are upgraded. It happens because OptionSet.parse() sets the configuration via the actions specified in the UpgradeCommand optionSet setup (and likewise in configuration builder as well). It only sets options that are saved, so if a later package does not have an option, it is not set, and the previous option is reused. This fixes the bug because it resets the configuration at the ChocolateyPackageService level, which is enough to reset the configuration for action that runs the PowerShell as well. Co-authored-by: TheCakeIsNaOH <TheCakeIsNaOH@gmail.com>

(#1443) Reset config via action after every package upgrade

AdmiringWorm · 2022-10-20T10:25:26Z

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

ferventcoder added 0 - Backlog 0 - _Triaging Bug Priority_HIGH labels Nov 6, 2017

ferventcoder added this to the 0.10.9 milestone Nov 6, 2017

ferventcoder mentioned this issue Dec 18, 2017

(git.install) Upgrades to 32-bit version when previously it have been installed as 64-bit chocolatey-community/chocolatey-packages#932

Closed

This was referenced Feb 10, 2018

Use Remembered Arguments for a Package During Upgrades #797

Closed

(chocolatey-core.extension) breaks Get-PackageParameters function if paramater contains spaces chocolatey-community/chocolatey-packages#950

Closed

ferventcoder changed the title ~~Upgrade all reuses overridden package parameters~~ Upgrade all reuses overridden package parameters when useRememberedArgumentsForUpgrades feature is turned on Feb 10, 2018

ferventcoder modified the milestones: 0.10.9, 0.10.10 Feb 12, 2018

ferventcoder modified the milestones: 0.10.10, 0.10.11 Mar 27, 2018

dinfinity mentioned this issue Apr 22, 2018

Chocolatey forgets packages where CTRL+C was pressed during upgrade #1548

Closed

ferventcoder modified the milestones: 0.10.11, 0.10.12 May 3, 2018

ferventcoder self-assigned this Dec 18, 2018

ferventcoder mentioned this issue Dec 30, 2018

Mixing remembered arguments between packages #1698

Closed

pauby mentioned this issue Jan 10, 2019

Choco update doesn't remember installation parameters #1707

Closed

gep13 added this to the 1.2.0 milestone Aug 11, 2022

pauby added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Aug 25, 2022

AdmiringWorm added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 20, 2022

(chocolatey#1443) Add E2E tests for remember upgrade args

75947c3

AdmiringWorm added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 21, 2022

(chocolatey#1443) Add E2E tests for remember upgrade args

2edef72

AdmiringWorm added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 21, 2022

(chocolatey#1443) Add E2E tests for remember upgrade args

70a2b07

AdmiringWorm added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 22, 2022

(chocolatey#1443) Add E2E tests for remember upgrade args

4fa6640

AdmiringWorm added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 22, 2022

(chocolatey#1443) Add E2E tests for remember upgrade args

5119f58

AdmiringWorm added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 22, 2022

(chocolatey#1443) Add E2E tests for remember upgrade args

b19e02e

corbob closed this as completed in #2484 Sep 22, 2022

corbob added a commit that referenced this issue Sep 22, 2022

Merge pull request #2484 from TheCakeIsNaOH/reset-config

3892cfb

(#1443) Reset config via action after every package upgrade

corbob added 4 - Done IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed 3 - Review ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Sep 22, 2022

AdmiringWorm added 5 - Released and removed 4 - Done labels Oct 20, 2022

This comment was marked as resolved.

Sign in to view

TheCakeIsNaOH mentioned this issue Jan 28, 2023

Potentially switch from remembering arguments to remembering configuration #3005

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade all reuses overridden package parameters when useRememberedArgumentsForUpgrades feature is turned on #1443

Upgrade all reuses overridden package parameters when useRememberedArgumentsForUpgrades feature is turned on #1443

dinfinity commented Nov 6, 2017 •

edited by ferventcoder

Loading

ferventcoder commented Nov 6, 2017 •

edited

Loading

ferventcoder commented Nov 6, 2017

dinfinity commented Nov 7, 2017

ferventcoder commented Feb 12, 2018

Vankog commented Mar 7, 2018

ferventcoder commented May 4, 2018

ferventcoder commented May 4, 2018

dinfinity commented Dec 28, 2018

AdmiringWorm commented Oct 20, 2022

This comment was marked as resolved.

Upgrade all reuses overridden package parameters when useRememberedArgumentsForUpgrades feature is turned on #1443

Upgrade all reuses overridden package parameters when useRememberedArgumentsForUpgrades feature is turned on #1443

Comments

dinfinity commented Nov 6, 2017 • edited by ferventcoder Loading

What You Are Seeing?

What is Expected?

How Did You Get This To Happen? (Steps to Reproduce)

Output Log

Related

ferventcoder commented Nov 6, 2017 • edited Loading

ferventcoder commented Nov 6, 2017

dinfinity commented Nov 7, 2017

ferventcoder commented Feb 12, 2018

Vankog commented Mar 7, 2018

ferventcoder commented May 4, 2018

ferventcoder commented May 4, 2018

dinfinity commented Dec 28, 2018

AdmiringWorm commented Oct 20, 2022

This comment was marked as resolved.

dinfinity commented Nov 6, 2017 •

edited by ferventcoder

Loading

ferventcoder commented Nov 6, 2017 •

edited

Loading