Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling error in "{packagename} has been upgradeed successfully." #64

Closed
kendaleiv opened this issue Feb 5, 2015 · 3 comments
Closed

Spelling error in "{packagename} has been upgradeed successfully." #64

kendaleiv opened this issue Feb 5, 2015 · 3 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_LOW Up For Grabs
Milestone
0.9.9.5

Comments

@kendaleiv
Copy link

"skype has been upgradeed successfully." was output with chocolatey v0.9.9-rc1.
@gep13
Copy link
Member

gep13 commented Feb 5, 2015

ah! The issue is here:

https://github.com/chocolatey/choco/blob/master/src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs#L209

The concatenation of upgrade and ed results in what you are seeing here. I can think of a couple hacks to make this work, but I will wait and get input from @ferventcoder before making any changes to the codebase.

Thanks for reporting this!

@christianrondeau
Copy link
Contributor

Hoping this will be fixed before 1.0... It makes chocolatey look unprofessional, and in the case of a package manager, trust and impressions are important :)

@ferventcoder ferventcoder mentioned this issue Apr 3, 2015
Closed
@ferventcoder ferventcoder assigned ferventcoder and unassigned gep13 Apr 3, 2015
@ferventcoder ferventcoder added this to the 0.9.9.5 milestone Apr 3, 2015
ferventcoder added a commit that referenced this issue Apr 3, 2015
@ferventcoder
(GH-64) Fix spelling error in upgrade message
91dc3f9 
Previously, due to concatenation of "ed" to the end of the command name
string, it caused a spelling error in the message for successful
upgrade: "packagename has been upgradeed successfully".

Without this change the spelling will continue to be incorrect and look
unprofessional.
ferventcoder added a commit that referenced this issue Apr 3, 2015
@ferventcoder
Merge branch 'stable'
9adaa02 
* stable:
  (GH-64) Fix spelling error in upgrade message
@ferventcoder
Copy link
Member

Fixed in 91dc3f9 to be out with 0.9.9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_LOW Up For Grabs
Projects
None yet
Milestone
0.9.9.5
Development

No branches or pull requests
4 participants
@ferventcoder @christianrondeau @kendaleiv @gep13