Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto Uninstaller should run every time #9

Closed
ferventcoder opened this issue Jan 11, 2015 · 0 comments · Fixed by #30
Closed

Auto Uninstaller should run every time #9

ferventcoder opened this issue Jan 11, 2015 · 0 comments · Fixed by #30
Assignees
@ferventcoder
Labels
5 - Released CoreTeam Improvement
Milestone
0.9.9

Comments

@ferventcoder
Copy link
Member

Whether or not the powershell ran. Sometimes the cleanup performed by a chocolateyUninstall may not also include the uninstall of a file and sometimes it may not do it quite right.
@ferventcoder ferventcoder modified the milestone: 0.9.9 Jan 11, 2015
@ferventcoder ferventcoder changed the title Auto Uninstaller Should run everytime Auto Uninstaller should run every time Jan 11, 2015
@ferventcoder ferventcoder self-assigned this Jan 17, 2015
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 19, 2015
@ferventcoder
(chocolateyGH-9)(refactor) autouninstaller code to a service
876189d 
Move the code for autouninstaller to its own service and remove the
stipulation that powershell needed to have NOT run for the
autouninstaller to run.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 19, 2015
@ferventcoder
(chocolateyGH-9)(refactor) invert ifs to return early
1ff59cf 
Remove nesting and return early.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 19, 2015
@ferventcoder
(chocolateyGH-9) RegistryService.value_exists
dcdaf0b 
Return whether a registry value exists.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 19, 2015
@ferventcoder
(chocolateyGH-9) Run AutoUninstaller every time
df245c1 
If the registry key AND the install location still exist, run
autouninstaller. Otherwise, skip and log the details.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 19, 2015
@ferventcoder
(chocolateyGH-9) delay cleanup on uninstall path
57d596a 
Remove uninstall executable from uninstall arguments before cleaning it
up for use by command executor.
@ferventcoder ferventcoder mentioned this issue Jan 19, 2015
Merged
3 tasks
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 19, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
220b52b 
WIP - specs are having issues running in isolation
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
f9e54b5 
WIP - specs are having issues running in isolation
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
f3608bb 
WIP - specs are having issues running in isolation
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
52e98fb 
WIP - specs are having issues running in isolation
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
e51c0cd 
WIP - specs are having issues running in isolation
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
81d0072 
WIP - specs are having issues running in isolation
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
5d47b3d 
- Move CommandExecutor away from static methods for the most part. Implement
ICommandExecutor and set it up with container binding. Set AutoUninstallerService
to use ICommandExecutor instead of static method calls.
- Fix null reference error in Registry ctor
- Log why when auto uninstaller is not run
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 20, 2015
@ferventcoder
(chocolateyGH-9) uninstall switch specs
651723b 
Ensure uninstaller uses the right switches on uninstall based on
HasQuietUninstall true or false.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9)(refactor) autouninstaller code to a service
9b640e1 
Move the code for autouninstaller to its own service and remove the
stipulation that powershell needed to have NOT run for the
autouninstaller to run.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9)(refactor) invert ifs to return early
bbb83b7 
Remove nesting and return early.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9) RegistryService.value_exists
68f743a 
Return whether a registry value exists.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9) Run AutoUninstaller every time
9495d76 
If the registry key AND the install location still exist, run
autouninstaller. Otherwise, skip and log the details.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9) delay cleanup on uninstall path
b17c226 
Remove uninstall executable from uninstall arguments before cleaning it
up for use by command executor.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9)(refactor) AutoUninstaller + Specs
02b57d5 
- Move CommandExecutor away from static methods for the most part. Implement
ICommandExecutor and set it up with container binding. Set AutoUninstallerService
to use ICommandExecutor instead of static method calls.
- Fix null reference error in Registry ctor
- Log why when auto uninstaller is not run
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 21, 2015
@ferventcoder
(chocolateyGH-9) uninstall switch specs
cab6105 
Ensure uninstaller uses the right switches on uninstall based on
HasQuietUninstall true or false.
ferventcoder added a commit that referenced this issue Jan 21, 2015
@ferventcoder
Merge pull request #30 from ferventcoder/ticket/master/autouninstaller
5f2d410 
(GH-15)(GH-9) AutoInstaller Enhancements
ferventcoder added a commit to ferventcoder/choco that referenced this issue Jan 22, 2015
@ferventcoder
(chocolateyGH-9) logging specs
1bd4934
@gep13 gep13 mentioned this issue Mar 15, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released CoreTeam Improvement
Projects
None yet
Milestone
0.9.9
Development

Successfully merging a pull request may close this issue.

(GH-15)(GH-9) AutoInstaller Enhancements ferventcoder/choco
2 participants
@ferventcoder @gep13