autoScroll #106
Merged
autoScroll #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is to facilitate the locking mechanism of cards for scroll
waltervan00
requested changes
Sep 24, 2021
oldbugo
approved these changes
Sep 25, 2021
shangzhel
reviewed
Sep 25, 2021
created 3 function for homeContext: lockCard, unlockCard, unlockCardLater
chomosuke
force-pushed
the
richard/autoScroll
branch
from
7154d16
to
6a6a03b
Compare
shangzhel
reviewed
Sep 27, 2021
shangzhel
approved these changes
Sep 27, 2021
… as no longer used according to https://reactjs.org/docs/hooks-reference.html#useref this is more correct
shangzhel
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior:
Once a card is clicked, it's locked, meaning it's y-position will not change.
User scrolling on the left side will unlock any locked card.
deselecting the card also unlock the card (though deselecting shouldn't change a locked card position).
if card grid's size is changed and no card is locked, the "scroll percentage" will be maintained (i.e. if it was at the very top, it'll stay there, if it was at the very bottom, it'll stay there, if it's anything in between, it'll scroll accordingly).
closes #77.