Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoScroll #106

Merged
merged 17 commits into from
Sep 27, 2021
Merged

autoScroll #106

merged 17 commits into from
Sep 27, 2021

Commits on Sep 23, 2021

  1. made Card.propTypes.card required

    @chomosuke
    chomosuke committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    4bfeadb View commit details
    Browse the repository at this point in the history

  2. planned in autoscroll.txt

    @chomosuke
    chomosuke committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    df07fb9 View commit details
    Browse the repository at this point in the history

  3. copied viewportsize from last sem

    @chomosuke
    chomosuke committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    232d642 View commit details
    Browse the repository at this point in the history

  4. moved showCardDetail to homecontext 

    this is to facilitate the locking mechanism of cards for scroll
    @chomosuke
    chomosuke committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    3b3a804 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. card maintain y position once selected

    @chomosuke
    chomosuke committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    62ad2ba View commit details
    Browse the repository at this point in the history

  2. User scrolling on the leftside will unlock any locked card.

    @chomosuke
    chomosuke committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    f2518b7 View commit details
    Browse the repository at this point in the history

  3. reorganized Home.tsx

    @chomosuke
    chomosuke committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    65071b7 View commit details
    Browse the repository at this point in the history

  4. maintained scroll percentage when no card is locked

    @chomosuke
    chomosuke committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    280ae58 View commit details
    Browse the repository at this point in the history

  5. removed autoScroll.txt

    @chomosuke
    chomosuke committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    3cc3201 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. fixed cardDelete bug

    @chomosuke
    chomosuke committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    d5cbf09 View commit details
    Browse the repository at this point in the history

  2. only autoscroll upon cardgrid size changes

    @chomosuke
    chomosuke committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    0a1ad11 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into richard/autoScroll

    @chomosuke
    chomosuke committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    7c5c239 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Merge branch 'master' into 'richard/autoScroll'

    @chomosuke
    chomosuke committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    5d261e2 View commit details
    Browse the repository at this point in the history

  2. moved showCardDetail back to AppContext 

    created 3 function for homeContext: lockCard, unlockCard, unlockCardLater
    @chomosuke
    chomosuke committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    6a6a03b View commit details
    Browse the repository at this point in the history

  3. lockCard take in ref insteaf of ref.current, deleted cardRefs in home… 

    … as no longer used

according to https://reactjs.org/docs/hooks-reference.html#useref this is more correct
    @chomosuke
    chomosuke committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    41198cd View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into richard/autoScroll

    @chomosuke
    chomosuke committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    cf9f165 View commit details
    Browse the repository at this point in the history

  5. insignificant changes for package-lock after running npm i

    @chomosuke
    chomosuke committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    89b98a9 View commit details
    Browse the repository at this point in the history