Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake Improve #3

Merged
merged 6 commits into from
Aug 25, 2019
Merged

CMake Improve #3

merged 6 commits into from
Aug 25, 2019

Conversation

yuki-koyama
Copy link
Contributor

Hi, thank you for sharing this useful library. This PR simply fixes some minor issues (which I believe are better to be fixed) in CMakeLists.txt. For example,

  • Paths are fixed (e.g., from src/*.cpp to SMPL++/src/*.cpp)
  • Unused libraries are removed (e.g., GLEW is linked but never used)

@chongyi-zheng
Copy link
Owner

Thanks for your contribution!

@chongyi-zheng chongyi-zheng merged commit 42f46f8 into chongyi-zheng:master Aug 25, 2019
@seong-heum seong-heum mentioned this pull request Sep 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-koyama @chongyi-zheng