-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configuration usage to cli #437
Conversation
- add configuration usage text - check for 'config' cmd when --help is used and output config usage text
😍 |
bin.js
Outdated
${clr(`{ | ||
"browserify": { | ||
"transform": [ | ||
[ "babelify", { "presets": [ "env" ] } ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a different example, since babelify is already included with this config by default. Not sure which transform would be a good alternative tho…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Maybe browserify-istanbul
?
It's hard, all my favorite browserify transforms are already used by Bankai 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeaap lol. Not sure about istanbul since it's used in production builds too. Maybe something like vueify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Made the changes using vueify. The appveyor build failed though, but it seems to be unrelated.
bin.js
Outdated
${clr(`{ | ||
"browserify": { | ||
"transform": [ | ||
[[ "vueify", { "sass": { "includePaths": [ "src/assets/css" ] } } ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there's one too many pairs of [] here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, I'll just remove them while merging :)
yay, thanks :D yeah, appveyor fails on the branch because config-usage doesn't have the config file (it was added after you branched off) so it tries to build it as c# or whatever. |
📦 9.9.0 |
:D |
This PR adds the enhancement discussed in #435