Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration usage to cli #437

Merged
merged 3 commits into from Mar 7, 2018
Merged

add configuration usage to cli #437

merged 3 commits into from Mar 7, 2018

Conversation

kareniel
Copy link
Member

This PR adds the enhancement discussed in #435

- add configuration usage text
- check for 'config' cmd when --help is used and output config usage
  text
@goto-bus-stop
Copy link
Member

😍

bin.js Outdated
${clr(`{
"browserify": {
"transform": [
[ "babelify", { "presets": [ "env" ] } ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a different example, since babelify is already included with this config by default. Not sure which transform would be a good alternative tho…

Copy link
Member Author

@kareniel kareniel Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Maybe browserify-istanbul?
It's hard, all my favorite browserify transforms are already used by Bankai 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeaap lol. Not sure about istanbul since it's used in production builds too. Maybe something like vueify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Made the changes using vueify. The appveyor build failed though, but it seems to be unrelated.

bin.js Outdated
${clr(`{
"browserify": {
"transform": [
[[ "vueify", { "sass": { "includePaths": [ "src/assets/css" ] } } ]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think there's one too many pairs of [] here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I'll just remove them while merging :)

@goto-bus-stop
Copy link
Member

yay, thanks :D yeah, appveyor fails on the branch because config-usage doesn't have the config file (it was added after you branched off) so it tries to build it as c# or whatever.

@goto-bus-stop goto-bus-stop merged commit 12ed72e into master Mar 7, 2018
@goto-bus-stop
Copy link
Member

📦 9.9.0

@kareniel
Copy link
Member Author

kareniel commented Mar 7, 2018

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants