add support for custom-self-closing elements #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyperx Empty/ Void Tags PR
Hyperx does not have support for custom elements to have self-closing tags (#47)- so this PR adds such functionality.
This PR does break one of the previous tests, where hyperx makes assumptions on which elements automatically support self closing tags. However these assumptions are made at the cost of parsing through a very large array of possible self-closing tags. (See below)
hyperx/index.js
Lines 265 to 281 in f3b8805
By removing this, we lose the functionality of being able to support widely known self-closing tags (such as
<input>
and<br>
) but the cost is relatively small (changing<br>
to<br />
and<input>
to<input />
) and has the benefit of support custom tags without adding them to a large list of supported closed tags.Included in this PR to make up for the lost test, are two new tests, which confirm that existing and custom elements will support self-closing tags.
Work done by @JRJurman and @ethanjurman