Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat single top-level array template part as a fragment #74

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Treat single top-level array template part as a fragment #74

merged 2 commits into from
Feb 19, 2019

Conversation

goto-bus-stop
Copy link
Member

Previously, this already generated a fragment, with 3 nodes:

hx`
  <a></a>
  ${[1, 2]}
`

It would make sense for this to also generate a fragment, with 2 nodes:

hx`
  ${[1, 2]}
`

yoshuawuyts
yoshuawuyts approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goto-bus-stop goto-bus-stop merged commit a535fd5 into master Feb 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the top-level-fragment branch February 19, 2019 12:00
@yoshuawuyts yoshuawuyts mentioned this pull request Feb 19, 2019
Closed
goto-bus-stop added a commit that referenced this pull request Feb 21, 2019
@goto-bus-stop
Revert "Treat single top-level array template part as a fragment (#74)"
1f85d7b 
This reverts commit a535fd5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @yoshuawuyts