Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit: cache dft & no apply #41

Closed
wants to merge 1 commit into from
Closed

emit: cache dft & no apply #41

wants to merge 1 commit into from

Conversation

yoshuawuyts
Copy link
Member

  • caches default routes
  • removes .apply() calls

A bit more messy, but probably faster

related to #40

@yoshuawuyts
Copy link
Member Author

cc/ @hughsk

@hughsk
Copy link
Collaborator

hughsk commented Dec 31, 2015

👏 🎉

@yoshuawuyts
Copy link
Member Author

pre patch benchmark

Running 10s test @ http://localhost:1337
  24 threads and 4000 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   740.99ms  401.90us 741.66ms   56.94%
    Req/Sec    16.76     34.83   166.00     92.68%
  745 requests in 10.11s, 518.43KB read
  Socket errors: connect 3757, read 0, write 0, timeout 673
Requests/sec:     73.70
Transfer/sec:     51.29KB

post patch

Running 10s test @ http://localhost:1337
  24 threads and 4000 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    40.46ms    5.47ms 171.02ms   82.23%
    Req/Sec   713.56      1.33k    4.98k    87.26%
  56524 requests in 10.10s, 6.95MB read
  Socket errors: connect 3757, read 0, write 0, timeout 0
Requests/sec:   5595.78
Transfer/sec:    704.94KB

@hughsk
Copy link
Collaborator

hughsk commented Dec 31, 2015

Whoa that's a huge improvement, nice one! 😁

@yoshuawuyts
Copy link
Member Author

haha, not sure benchmarks hold up. I've changed more stuff (can't reproduce). But hey, it's most likely better haha

@yoshuawuyts
Copy link
Member Author

lol, ok it wasn't that. But hey, perf!

@yoshuawuyts
Copy link
Member Author

I ran some other checks, and I don't believe this sped up things by a lot. Perhaps revisit later, but for now it's probably good enough

@yoshuawuyts yoshuawuyts deleted the unwrap branch March 29, 2016 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants