Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choo@6, bankai@6, style tweaks #15

Merged
merged 7 commits into from
Aug 12, 2017
Merged

choo@6, bankai@6, style tweaks #15

merged 7 commits into from
Aug 12, 2017

Conversation

ungoldman
Copy link
Member

@ungoldman ungoldman commented Aug 10, 2017

This PR bumps choo and bankai to v6 and updates the site code to use the newer APIs. Also tweaked the styles for the index a bit. Hope you like it!

If you'd prefer I break this out into two PRs (one for version bumps, one for style) I can do that too, just did this quickly on my lunch break today.

localhost-8080- laptop with hidpi screen 1

@toddself
Copy link

dang this looks good!

@ungoldman
Copy link
Member Author

Rebased after merging #10

Copy link

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yoshuawuyts: ungoldman: neat!
02:20 ungoldman: would be cool to get the weird kerning back at some point; but what you got is better than the broken version currently live. Merge away!

@ungoldman
Copy link
Member Author

Ok, added letter spacing back to choo in the title by popular demand, and tweaked footer to be same width as rest of sections. Looks alright when emulating mobile styles and I got the ok from #choo channel so I'm merging away.

w o o 🎉

@ungoldman ungoldman merged commit b7302f0 into master Aug 12, 2017
@ungoldman ungoldman deleted the ng/choo-6 branch August 12, 2017 04:58
@bcomnes
Copy link

bcomnes commented Aug 12, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants