Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

broadcast discovery should create a timeout context used by the client #25

Closed
ripienaar opened this issue Jul 12, 2018 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@ripienaar
Copy link
Contributor

When doing discovery the supplied context is used verbatim:

https://github.com/choria-io/go-client/blob/3abc5542c103b7a2c1990c099097dc756c0de4dc/discovery/broadcast/broadcast.go#L85

This means that if the initial connection fails or whatever - it's going to be stuck here forever rather than discovery timeout period. Probably we need a initial connect timeout rather than a whole timeout over the entire discovery but for now lets just wrap the whole client request in a context and give it timeout+2

@ripienaar ripienaar added the bug Something isn't working label Jul 12, 2018
ripienaar added a commit that referenced this issue Jul 12, 2018
(#25) ensure initial connection will eventually timeout in discovery
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant