Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative urls correctly with a reverse proxy #74

Merged
merged 3 commits into from
Oct 19, 2017

Conversation

Avsecz
Copy link
Contributor

@Avsecz Avsecz commented Oct 8, 2017

Allows sacredboard to run behind a reverse proxy,

  • added the sub_url CLI flag (following this blog post).
  • jquery ajax calls now use relative url's (replaced "/app/run" -> "app/run") in .js files

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 78.907% when pulling c3c53e6 on Avsecz:develop into 510e7a5 on chovanecm:develop.

@chovanecm chovanecm self-requested a review October 19, 2017 19:32
@chovanecm chovanecm merged commit c3c53e6 into chovanecm:develop Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants