ERROR: Crashed with fix_skill_name() missing 1 required positional argument: 'skill_name'

[chalkos]

Hi, I was trying to use your tool and it just stopped after a while:

app.log:

src.charm_extraction - ERROR - Crashed with fix_skill_name() missing 1 required positional argument: 'skill_name'

And frame2390:

I moved frame2390 out of the folder, emptied out the inputs folder and ran it again.
It failed on this one:

At least there is a pattern :)
I repeated the process and it ran to the end and out of 546 frames it saved 516 charms (I may have gone over some of them more than once so those should all be duplicates).

It correctly identified these ones that have Flinch Free (I verified that I have them):

Counterstrike,1,Flinch Free,1,1,1,0
Evade Extender,2,Flinch Free,1,2,1,0
Flinch Free,1,Bombardier,2,2,1,0
Flinch Free,1,Diversion,1,2,1,0
Flinch Free,1,Reload Speed,1,2,1,1
Flinch Free,1,Resuscitate,1,1,1,0
Flinch Free,2,,0,1,1,0
Flinch Free,2,Dragon Attack,2,3,1,0
Flinch Free,2,Guard,1,1,1,0
Flinch Free,2,Hellfire Cloak,1,1,1,0
Flinch Free,2,Horn Maestro,1,2,0,0
Flinch Free,2,Leap of Faith,1,2,2,0
Flinch Free,3,Paralysis Resistance,1,2,0,0
Flinch Free,3,Sleep Attack,1,1,0,0
Fortify,1,Flinch Free,1,1,0,0
Leap of Faith,1,Flinch Free,1,2,1,0
Punishing Draw,1,Flinch Free,1,1,1,0
Slugger,2,Flinch Free,2,2,1,0

let me know if you want the pictures for any of these or need anything else to find out what's causing this problem.

And thanks for this tool, no way I was going to add 500 talismans to the builder otherwise 😄

[chpoit]

I've rolled this into the "1.2" update, I should push it within an hour.

It happened because it ran a bit of code that went untested since I updated the Google Tesseract version.

Thanks a lot for the report.

Closed by #8

[chalkos]

Awesome. Thanks!

[chpoit]

Just finished uploading if you wouldn't mind trying the new version:
https://github.com/chpoit/utsushis-charm/releases/latest

[chalkos]

It worked without the error. And it is much faster processing the videos.
And it detected more charms now.. 528 instead of 516

[chalkos]

In case you're wondering what it detected now that wasn't detected before, I sorted the charms.encoded.txt and made a diff:

--- Utsushis-Charm_v1_1\charms.encoded.txt	Wed May 12 16:45:50 2021
+++ Utsushis-Charm_v1_2\charms.encoded.txt	Wed May 12 16:45:50 2021
@@ -50,6 +50,7 @@
 Bubbly Dance,2,Blight Resistance,1,1,1,1
 Bubbly Dance,2,Counterstrike,1,2,1,0
 Bubbly Dance,2,Heroics,1,1,0,0
+Bubbly Dance,2,Paralysis Resistance,2,2,1,1
 Bubbly Dance,2,Power Prolonger,2,1,0,0
 Bubbly Dance,2,Punishing Draw,1,0,0,0
 Bubbly Dance,2,Sleep Resistance,2,2,1,0
@@ -120,6 +121,7 @@
 Dragon Attack,2,Blight Resistance,2,2,1,0
 Dragon Resistance,1,Critical Boost,1,0,0,0
 Dragon Resistance,1,Paralysis Resistance,1,2,1,0
+Dragon Resistance,1,Punishing Draw,1,1,0,0
 Dragon Resistance,1,Slugger,1,1,1,0
 Dragon Resistance,1,Stamina Surge,2,0,0,0
 Dragon Resistance,1,Windproof,2,0,0,0
@@ -182,10 +184,12 @@
 Flinch Free,1,Resuscitate,1,1,1,0
 Flinch Free,2,,0,1,1,0
 Flinch Free,2,Dragon Attack,2,3,1,0
+Flinch Free,2,Evade Extender,1,1,1,1
 Flinch Free,2,Guard,1,1,1,0
 Flinch Free,2,Hellfire Cloak,1,1,1,0
 Flinch Free,2,Horn Maestro,1,2,0,0
 Flinch Free,2,Leap of Faith,1,2,2,0
+Flinch Free,2,Rapid Morph,1,2,1,0
 Flinch Free,3,Paralysis Resistance,1,2,0,0
 Flinch Free,3,Sleep Attack,1,1,0,0
 Fortify,1,Botanist,1,3,2,0
@@ -224,7 +228,10 @@
 Heroics,2,,0,1,0,0
 Heroics,2,,0,2,1,1
 Horn Maestro,1,Focus,1,0,0,0
+Horn Maestro,1,Ice Resistance,1,2,1,0
+Horn Maestro,1,Master Mounter,1,1,1,0
 Horn Maestro,1,Maximum Might,1,3,1,0
+Horn Maestro,1,Partbreaker,1,3,0,0
 Horn Maestro,1,Poison Resistance,1,1,1,0
 Hunger Resistance,1,Razor Sharp,1,1,0,0
 Hunger Resistance,1,Weakness Exploit,1,0,0,0
@@ -283,6 +290,7 @@
 Muck Resistance,2,,0,3,1,0
 Mushroomancer,1,Bludgeoner,2,0,0,0
 Normal/Rapid Up,2,,0,0,0,0
+Paralysis Attack,1,,0,0,0,0
 Paralysis Attack,2,,0,1,1,1
 Paralysis Attack,2,Power Prolonger,1,0,0,0
 Paralysis Resistance,1,Punishing Draw,1,1,0,0
@@ -325,6 +333,7 @@
 Punishing Draw,2,Hunger Resistance,2,0,0,0
 Punishing Draw,2,Spare Shot,2,1,0,0
 Punishing Draw,2,Wide-Range,1,2,1,0
+Quick Sheath,1,Free Meal,2,2,1,0
 Quick Sheath,1,Speed Eating,1,3,0,0
 Quick Sheath,2,Resuscitate,1,1,1,0
 Quick Sheath,3,Ice Resistance,2,2,0,0
@@ -351,6 +360,7 @@
 Recovery Speed,2,Speed Sharpening,1,3,2,0
 Recovery Speed,3,Partbreaker,2,0,0,0
 Recovery Up,2,,0,2,1,0
+Recovery Up,2,Critical Eye,1,0,0,0
 Recovery Up,2,Free Meal,2,3,0,0
 Recovery Up,2,Paralysis Attack,1,1,0,0
 Recovery Up,2,Resuscitate,1,1,0,0
@@ -425,6 +435,7 @@
 Stamina Thief,2,Rapid Morph,1,0,0,0
 Stamina Thief,3,Poison Resistance,1,1,0,0
 Steadiness,1,,0,2,0,0
+Steadiness,1,Carving Pro,1,1,1,0
 Steadiness,1,Earplugs,2,1,1,0
 Steadiness,1,Peak Performance,1,1,1,0
 Steadiness,1,Wirebug Whisperer,2,1,1,0
@@ -506,6 +517,7 @@
 Windproof,1,Steadiness,2,1,1,0
 Windproof,1,Tremor Resistance,1,3,0,0
 Windproof,2,,0,0,0,0
+Windproof,2,Defense Boost,1,3,2,0
 Windproof,2,Maximum Might,1,1,1,0
 Windproof,2,Paralysis Attack,1,0,0,0
 Windproof,2,Wall Runner,1,0,0,0