Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use modified_model in Composites example #64

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

rodrigobdz
Copy link
Contributor

In the with statement, the variable modified_model was not used to compute the output and the original model was used instead.

In the `with` statement, the variable modified_model was not used to compute the output and the original model was used instead.
@chr5tphr
Copy link
Owner

chr5tphr commented Dec 7, 2021

Hey Rodrigo,

thank you for the fix!
Just as a side note, both model and modified_model describe the same object, since composites (and also attributors) temporarily change models in-place for the duration of the context. The context variable is used for clarity.

@chr5tphr chr5tphr merged commit 7c8ab0d into chr5tphr:master Dec 7, 2021
@rodrigobdz rodrigobdz deleted the patch-1 branch December 7, 2021 14:24
@rodrigobdz
Copy link
Contributor Author

@chr5tphr Glad to help!
I see, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants