Add support for Mangler charged shots when attack2fire is enabled

[jedso]

Currently alt-fire charged shots do not work with the Cow Mangler 5000 when attack2fire is enabled because m_flNextSecondaryAttack will always be set to g_globals.curtime + 0.5:

jumpqol/jumpqol.sp

Lines 2838 to 2841 in 306739d

	if (GetEntProp(entity, Prop_Data, "m_iClip1") != 0)
	SetEntPropFloat(entity, Prop_Send, "m_flNextSecondaryAttack", g_globals.curtime + 0.5);
	else
	SetEntPropFloat(entity, Prop_Send, "m_flNextSecondaryAttack", g_globals.curtime - g_globals.interval_per_tick);

This PR adds a check for if the Mangler is fully charged, and if so, sets m_flNextSecondaryAttack to g_globals.curtime - g_globals.interval_per_tick.

The Mangler is not affected by the same reload problem fixed in 9002a10 when all ammo runs out (+ m_iClip1 doesn't decrement), so that check no longer runs.

[chrb22]

I did think about it when I was implementation attack2fire, but I decided against it. The setting is really only meant for people with butterfingers and if you're running mangler with the intention of using a charged shot at some point, then you don't fall into that category. I suppose you could switch to mangler for a moment to do a charged bounce setup. If something like that is your intention, then I'd say it would be better to make the setting integer valued and having attack2fire = 2 use your fix, while keeping attack2fire = 1 as-is for its intended purpose.

[jedso]

The setting is really only meant for people with butterfingers and if you're running mangler with the intention of using a charged shot at some point, then you don't fall into that category

Fair enough. The bigger issue for me was that I was trying to do a charged shot, it wasn't working and I didn't immediately know why. Currently attack2fire is on by default, and without knowing that or knowing more broadly about this plugin and how each of the settings work, I would argue it can be a bit of a confusing experience (as it was for me). In my view, as long as attack2fire remains opt-out by default, core weapon functionality such as alt-fire charged shots should continue to work as expected.

If something like that is your intention, then I'd say it would be better to make the setting integer valued and having attack2fire = 2 use your fix, while keeping attack2fire = 1 as-is for its intended purpose.

I don't mind this solution, although I would argue that the default should become 2 in that case for better UX (i.e. it would make disabling charged shots a purposeful decision rather than one where the user has to hunt down a reason for why it's not working). All good if you disagree with this assessment, though. After all, choosing to do a charged setup is reasonably uncommon. You make the call.

[chrb22]

To me it makes the most sense to have attack2fire enabled by default because that would be preferable for the vast majority of time you're playing. I think it would be better to just have a small chat message the first time a player hits secondary fire with a fully loaded mangler for them to learn about the setting.

[jedso]

I think it would be better to just have a small chat message the first time a player hits secondary fire with a fully loaded mangler for them to learn about the setting.

OK, sounds good. Feel free to refactor/change any of how I implemented this.

[chrb22]

Seems good. Going to also make it override +attack2 while +attack is held and some other misc stuff. Also going to remove the GetEntProp(entity, Prop_Data, "m_iClip1") check because I have no idea why I put that there.

[jedso]

Also going to remove the GetEntProp(entity, Prop_Data, "m_iClip1") check because I have no idea why I put that there.

I think you added it to handle when clip ammo and reserve ammo reach 0 for all non-Mangler launchers. Without that check, once you reach 0 ammo, the weapon stays equipped rather than switching to the next usable weapon (CBaseCombatWeapon::ReloadOrSwitchWeapons).

[chrb22]

I don't remember that being the reason, but it's enough reason to add it back. Thanks for checking.