-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion problem with two levels or more of ../ #57
Comments
Thank you for reporting this. I see where the problem is occurring, and it only happens for built in match generators for the first word (and only when |
Using `path.normalise()` condenses `.\` and `..\` components, which breaks filtering matches. Instead only replace `/` with `\`.
It turns out that in CMD typing And I fixed Clink to work accordingly some time ago. So, this issue 57 is back to "not working". Except that it's actually technically working properly now. 🙃 Trying to make I feel that it's appropriate for Clink to match how CMD actually works. So, I'm going to let issue 57 stay "broken" since that's actually "correct". Sorry that it's so confusing. Windows and CMD are not the same as Linux and bash, and Clink can't overcome that all by itself, at least not without breaking normal Windows and CMD behaviors (which causes other problems). |
Or, if you want to type I know it isn't like bash or Linux. But this isn't bash or Linux, and it's important to stay compatible with how CMD actually works. |
clink.filematches() always converted forward slashes to backslashes, related to #57. But it shouldn't convert slashes there, and also it wasn't correct to treat `../foo` as a relative path anyway, since CMD actually interprets `foo/bar` as `foo /bar` -- the slash is interpreted as a switch character, not as a path separator. Additionally, this change also makes "off" mode preserve typed forward slashes and backslashes (e.g. completing `/foo/` became `/foo\bar\`, but the expected behavior is really `/foo/bar\`).
Hello,
First, thank you for keeping this marvellous tool alive!
I have just migrated from 0.4.9 to 1.1.22 and so far so good, everything is Ok, except one thing.
If I complete more than one ../, only the last slash is converted to backslash. It's ok to change directory but not for executing programs ('..' is not recognized as an internal command or etc.).
Or maybe I missed something in the help file. I've made nearly no tuning to feel at home with your version, keeping previous settings file (almost vanilla from 0.4.9), history and just binding scrolling to Shift-PgUp/PgDn in .inputrc.
Do you experience the same behaviour?
Regards,
The text was updated successfully, but these errors were encountered: