Fixing some code declarations #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your commit looks correct, I've also noticed these typos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I'm using php-diff in a project of mine, and I ran a php-lint like software called xref, https://github.com/gariev/xref , and it pointed me to two different possible bugs in the php-diff code. I've tested this change as best as I can, but I'm not 100% sure I was ever even hitting this code.
I'm submitting this too you in the hopes of you either telling me that no these aren't bugs, or yes they are.
Either way, I just want to say thanks, and I appreciate you putting this library together in the first place.
Cheers,