begin to add uniformData #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… line breaks (flutter#21356) This is similar to the workaround used for flutter/flutter#30347 The Minikin line breaker inserts greedy breaks based on a comparison of postBreak width and currentLineWidth. currentLineWidth is provided by the framework based on previous calls to Layout::measureText. That calculation may not exactly match the calculation of postBreak. This change ensures that breaks are only added if the difference between postBreak and currentLineWidth is significant. Fixes flutter/flutter#65419
Previously, the selection base and extent were stored internally as iterators over text_. Since iterators must be treated as invalidated whenever the underlying container changes, this requires that selection_base_ and selection_extent_ be re-assigned after every change to text_. This is not currently particularly problematic, but once we add fields to track the base and extent of the composing region for multi-step input method support, as well as support for the sub-range within the composing region to which edits/completions apply, we end up having to regenerate a lot of iterators with each change, many of which are logically unchanged in position. A side benefit is that this simplifies inspection of these fields when debugging.
Neither of these methods mutate the state of the model.
…dating the asset directory (flutter#21611) Follow up from flutter#21436 . That PR works for all embeddings except for Android, which creates a special JNI AssetResolver. Since the shell cannot recreate this resolver, update the logic to preserve existing resolvers instead.
…release mode build (flutter#21668)
…1610) * fixing the autofill overlay problem (blue area for chrome) * addression comments
As fl_renderer_wayland.cc uses directly some of the wayland-client related functions it should also add this library as a dependency.
…ection.sendKeyEvent on Android (flutter#21979) This re-lands flutter#21163, which was reverted in flutter#21513 Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent. Here's the original PR description: This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework. It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework). This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system. Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
…nputConnection.sendKeyEvent on Android (flutter#21979)" (flutter#22004) This reverts commit 3cd70f2 because it causes some failures in web tests.
https://dart.googlesource.com/sdk.git/+log/fc82eeed7df3..8be6a08153cc 2020-10-20 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.11.0-238.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
The new map() method receives its arguments in the same order as the underlying C system call. This patch should not change any behavior.
https://skia.googlesource.com/skia.git/+log/1c823674d957..2d2f82c00aeb 2020-10-20 brianosman@google.com Always declare sk_FragColor in GLSL, even if unused 2020-10-20 ethannicholas@google.com added SkSLNodeArrayWrapper 2020-10-20 reed@google.com update dox for drawPaint 2020-10-20 johnstiles@google.com Wrap built-in symbol tables during inlining. 2020-10-20 johnstiles@google.com Wrap built-in symbol tables when an IRNode is cloned. 2020-10-20 johnstiles@google.com Fix typo in class name. 2020-10-20 robertphillips@google.com Make GrFillRectOp::onPrePrepareDraws also call base class' version 2020-10-20 adlai@google.com Reland "Remove GrContext" 2020-10-20 robertphillips@google.com Rename some of GrThreadSafeCache's member variables 2020-10-20 abarth@google.com [fuchsia] Migrate to new zx::vmar::map method 2020-10-20 mtklein@google.com upstream cl/337571894 with tweaks 2020-10-20 robertphillips@google.com Pull the triangulating path renderer's shape-space triangulation into a helper method 2020-10-20 fmalita@chromium.org [svg] Parse text attributes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
https://dart.googlesource.com/sdk.git/+log/874709e52a99..a3d902d8598e 2020-10-21 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.11.0-242.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
…in the running phase. (flutter#22041) Embedders that have access to the Dart native API (only Fuchsia now) may perform library setup in the isolate create callback. The engine used to depend on the fact the root isolate entrypoint is invoked in the next iteration of message loop (via the `_startIsolate` trampoline in `isolate_patch.dart`) to ensure that library setup occur before the main entrypoint was invoked. However, due to differences in the way in which message loops are setup in Fuchsia, this entrypoint was run before the callback could be executed. Dart code on Fuchsia also has the ability to access the underlying event loops directly. This patch moves the invocation of the create callback to before user dart code has a chance to run. This difference in behavior on Fuchsia became an issue when the isolate initialization was reworked in flutter#21820 for null-safety. Another issue was discovered in that the callback was being invoked twice, I fixed that too and added a test. Fixes flutter/flutter#68732
…tance. (flutter#22052) This regression was introduced in flutter#21820 for sound-null safety. The settings used to launch the VM were incorrectly used to determine the isolate lifecycle callbacks. Since the first shell/engine in the process also starts the VM, these objects are usually identical. However, for subsequent engine shell/engine launches, the callbacks attached to the new settings object would be ignored. The unit-test harness is also structured in such a way that each test case tears down the VM before the next. So all existing tests created a bespoke VM for the test run, and, the tests that did create multiple isolates did not also test attaching callbacks to the settings object. Fixes flutter#22041
https://skia.googlesource.com/skia.git/+log/2d2f82c00aeb..5c7bb326a7b3 2020-10-22 johnstiles@google.com Reland "Create a basic IRNode pooling system." 2020-10-22 egdaniel@google.com Revert "Reland "Create a basic IRNode pooling system."" 2020-10-22 egdaniel@google.com Revert "Add pooling support on iOS." 2020-10-22 brianosman@google.com Add much better SkTHashMap visualization to Skia.natvis 2020-10-22 kjlubick@google.com [fuzz] Copy crashing outputs before failing 2020-10-22 johnstiles@google.com Add pooling support on iOS. 2020-10-22 jvanverth@google.com Fix storage class issues for push constant variables. 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 84f5eeb6dd9b to e02d8938821a (3 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4bdce889ea35 to 502ec4ce30b3 (465 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e2147a5 to d747543 (16 revisions) 2020-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from cca03ca6bfe9 to 22505a5afe1f (9 revisions) 2020-10-22 johnstiles@google.com Reland "Create a basic IRNode pooling system." 2020-10-21 fmalita@chromium.org [svg] Add support for preserveAspectRatio 2020-10-21 johnstiles@google.com Pop the symbol table if compilation fails. 2020-10-21 kjlubick@google.com [canvaskit] Load resources into wasm gms/unit tests. 2020-10-21 egdaniel@google.com In Vk don't set dynamic blend constant on Pipeline if we don't use it. 2020-10-21 tdenniston@google.com [svg] Add gradientUnits attribute, value, and parsing 2020-10-21 jlavrova@google.com Underline decorations with gaps and no text 2020-10-21 bsalomon@google.com Reland "Perform bounding rect-relative calcs in full float in GrRRectBlurEffect" 2020-10-21 brianosman@google.com Add several more visualizations to Skia.natvis 2020-10-21 michaelludwig@google.com Make small epsilons more rigorous for gpu gaussian blurs 2020-10-21 johnstiles@google.com Revert "Create a basic IRNode pooling system." 2020-10-21 bsalomon@google.com Revert "Perform bounding rect-relative calcs in full float in GrRRectBlurEffect" 2020-10-21 johnstiles@google.com Migrate additional FPs to `return` instead of `sk_OutColor`. 2020-10-21 johnstiles@google.com Wrap built-in symbol tables when a switch statement is cloned. 2020-10-21 bsalomon@google.com Perform bounding rect-relative calcs in full float in GrRRectBlurEffect 2020-10-21 johnstiles@google.com Create a basic IRNode pooling system. 2020-10-21 robertphillips@google.com Increase encapsulation of GrThreadSafeCache::Entry 2020-10-21 kjlubick@google.com [canvaskit] Fix gm test runner on non-tryjobs 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from df17a76102df to 84f5eeb6dd9b (3 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2be3568 to e2147a5 (40 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 60b90a0bfd24 to 4bdce889ea35 (441 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c4593127cbdd to cca03ca6bfe9 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're
modifying existing behavior, describe the existing behavior, how this PR is
changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue
database. Indicate, which of these issues are resolved or fixed by this PR.
There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A
change in behaviour with no test covering it will likely get reverted
accidentally sooner or later. PRs must include tests for all
changed/updated/fixed behaviors. See testing the engine for instructions on
writing and running engine tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.