Refactor Smaug wallet db file deletion #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisguida
reviewed
Jan 13, 2024
src/main.rs
Outdated
| Err(e) => return Err(e), | ||
| } | ||
| }, | ||
| None => "Removed wallet was None!".to_string(), |
There was a problem hiding this comment.
Return from function with error here instead of storing an error message into db_file_path
fmhoeger
force-pushed
the
refactor-smaug-db-file-deletion
branch
2 times, most recently
from
8b47f92
to
d01c1d5
Compare
fmhoeger
force-pushed
the
refactor-smaug-db-file-deletion
branch
from
1b8f587
to
e463f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unwrap()withmatchexpressions