Fix for issue #4: convert the color value even with text following it #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After taking a look at the code, docs and tests I believe that you are using the framework in a way that it's not intended to be used. Anything you put after does not seem to do anything really. @christian-bromann Please correct me if I am wrong on this. |
|
I believe that @erwinheitzman is correct, I was using the wrong CSS property to get the color and I never realized because the previous versions of rgb2hex were more permissible in handling this bad case. Using the proper CSS property solves my issue and I updated issue #4 to reflect that. It seems perfectly legitimate to reject this PR. Again, many thanks to @erwinheitzman for pointing me in the right direction! |
|
Thanks @erwinheitzman , I think I gonna reject this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the same behavior as discussed in issue #4. I believe the issue is that we assume that there will be nothing following the color value, which is not true for me and as seen in the issue.
Added unit tests to cover both rgb and rgba colors with attribute text following it (which happens with webdriverio's getCssProperty).