Merge pull request #148 from toebsen/fix_eth_transport_reconnect

fix trying to restart threads when connecting multiple times
christoph2 · Oct 13, 2023 · 3b95897 · 3b95897
2 parents 6442f5e + 2a9f680
commit 3b95897
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/pyxcp/transport/base.py b/pyxcp/transport/base.py
@@ -216,8 +216,12 @@ def connect(self):
         pass
 
     def startListener(self):
-        if not self.listener.is_alive():
-            self.listener.start()
+        if self.listener.is_alive():
+            self.finishListener()
+            self.listener.join()
+
+        self.listener = threading.Thread(target=self.listen)
+        self.listener.start()
 
     def finishListener(self):
         if hasattr(self, "closeEvent"):

diff --git a/pyxcp/transport/eth.py b/pyxcp/transport/eth.py
@@ -90,8 +90,11 @@ def connect(self):
             self.status = 1  # connected
 
     def startListener(self):
+        super().startListener()
+        if self._packet_listener.is_alive():
+            self._packet_listener.join()
+        self._packet_listener = threading.Thread(target=self._packet_listen)
         self._packet_listener.start()
-        self.listener.start()
 
     def close(self):
         """Close the transport-layer connection and event-loop."""

diff --git a/pyxcp/transport/usb_transport.py b/pyxcp/transport/usb_transport.py
@@ -90,8 +90,11 @@ def connect(self):
         self.status = 1  # connected
 
     def startListener(self):
+        super().startListener()
+        if self._packet_listener.is_alive():
+            self._packet_listener.join()
+        self._packet_listener = threading.Thread(target=self._packet_listen)
         self._packet_listener.start()
-        self.listener.start()
 
     def close(self):
         """Close the transport-layer connection and event-loop."""