-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default generated password length *back* to eight characters #1
Comments
Hmm. The default is in fact 8 characters. You can confirm this by opening an incognito window in Chrome and loading the mobile version of GenPass. I think the issue is probably a collision with SGP preferences. Both SGP and GP now use the same domain, so the values overwrite each other if you use both. Do you think this might explain it? I will work on namespacing the preferences so they don't collide. |
@chriszarate that makes sense, and I can confirm that using my genpass bookmarklet in an incognito window gets me back to 8 characters. Thanks! |
I've run into this same bug and it's certainly caused by having both bookmarklets in use on different domains for me. I'd definitely prefer something more akin to the older style bookmarklets (I'd lose the pretty stylings, but I can survive!). Since I routinely switch between the two bookmarklets for sites, I'd really like to not have to manually change between 8 and 10 each time I do so. Another question (maybe I should just open another issue?) is there a build that doesn't check for new updates? I'd definitely like to disable this feature since the whole value for me is that the bookmarklets have been (historically) self-contained. I'd take a stab at it changing these things myself, but it's not entirely clear for me what generates the minified version from the full-size. I guess it doesn't matter and I could just use anything? Still, if I'm going to fork, it'd be preferable to do it with as few changes as possible. |
Apologies for not digging more into the details here but I noticed that in the few places where I still have 'legacy' genpass passwords my logins were failing and it seemed to be because the latest bookmarklet defaults to generating a 10 character password when the old default was 8 characters.
The text was updated successfully, but these errors were encountered: