-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: log output path or log config path as environment variable or CLI option #1591
Comments
Hey @rudolfolah, I am glad you find the CLI useful. The team is looking to expand its functionality and usefulness, and what you suggest regarding the logging path falls within that category of improvements. This should be pretty easy to add to the codebase, but let us spend a few moments considering the overall logging situation as this may also present an opportunity for improvement. |
Thanks for the quick response, that sounds like a good plan. And this may be useful to someone else, here's how I got it working with systemd:
|
…a log_config.yml Refs: chroma-core#1624, chroma-core#1591
Refs: #1624, #1591 ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Added `--log--path` support to the CLI. A naive implementation that works with Chroma's `log_config.yml` ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python ## Documentation Changes TBD
Just saw the merged PR that references this issue, awesome work! |
Describe the problem
Currently, the log output path goes to
chroma.log
located near thechromadb_path
.Overriding it, based on the CLI code, means copying/pasting the
log_config.yml
and rewriting the configuration to point to a different logging path.It would be great to be able to specify the exact path where the log file should be stored or to point to a different configuration file path.
Describe the proposed solution
Support CHROMA_LOG_OUTPUT_PATH as an environment variable or
--log-output
as a command-line argumentAlternatives considered
Alternatively, allow the
log_config.yml
path to be specified so that the configuration for logging can be completely customized:Importance
would make my life easier
Additional Information
No response
The text was updated successfully, but these errors were encountered: