Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show build progress on 'no build' screen #107

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Sep 15, 2023

Screenshot 2023-09-15 at 16 12 25
📦 Published PR as canary version: 0.0.76--canary.107.70e25d3.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.76--canary.107.70e25d3.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.76--canary.107.70e25d3.0

@linear
Copy link

linear bot commented Sep 15, 2023

AP-3657 First build in progress state

As described:

https://linear.app/chromaui/issue/AP-3621/improve-first-build-error-handling#comment-1b9a109b

Show a progress bar with a description for the "first build" on a branch:

Screenshot 2023-09-14 at 22.14.52.png

This could probably be the same as the progress bar in the tooltip of the SidebarTopButton.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I love it.

@tmeasday tmeasday merged commit 05639b3 into main Sep 16, 2023
6 checks passed
@tmeasday tmeasday deleted the ghengeveld/ap-3657-first-build-in-progress-state branch September 16, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants