-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new invalid sb base dir error message and validator function #921
Add new invalid sb base dir error message and validator function #921
Conversation
@ghengeveld some unrelated tests are now breaking because of the check I put in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Needs a little work to safeguard performance but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 PR was released in |
We will now check if the
storybookBaseDir
is valid before letting the build continue. If it is not defined but needs to be, or is defined but does not point to the correct location, the build will fail and an error will be displayed.QA
--only-changed
and an invalid--storybook-base-dir
npx chromatic@<CANARY_VERSION> --only-changed --storybook-base-dir "src/foobar"
📦 Published PR as canary version:
12.0.0--canary.921.8007225252.0
✨ Test out this PR locally via:
npm install chromatic@12.0.0--canary.921.8007225252.0 # or yarn add chromatic@12.0.0--canary.921.8007225252.0