Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead reference to createTask? #1

Closed
Anahkiasen opened this issue Apr 13, 2018 · 1 comment
Closed

Dead reference to createTask? #1

Anahkiasen opened this issue Apr 13, 2018 · 1 comment

Comments

@Anahkiasen
Copy link

Anahkiasen commented Apr 13, 2018 •
edited
Loading

Following the guide currently, arrived at this page and I noticed a paragraph referencing code which I think changed since:

createTask() is a helper function that generates shape of a Task that we created and exported from the Task.stories.js file. Similarly, actions exported from Task.stories.js defined the actions (mocked callbacks) that a Task component expects, which the TaskList also needs.

Couldn't find any reference to a createTask so I'm assuming this was changed after this was written
domyen added a commit to chromaui/learnstorybook.com that referenced this issue Apr 13, 2018
@domyen
Dead reference, thanks @Anahkiasen
454b8ad 
chromaui/learnstorybook-code#1
@domyen
Copy link
Member

domyen commented Apr 13, 2018

Bingo! We just merged a PR that refactored how this was done. I'll make the necessary edits.

@domyen domyen closed this as completed Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domyen @Anahkiasen