Removed styling only addressed in topic 'Addons' #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rial. In the topic 'Addons' this component is tested by using the Controls Addon. At this point the overflow behavior with long strings is addressed by adding the styling and a visual regression test. Since this style is already added at the start of the course, someone following along the tutorial will not see the text overflow the component like in the examples. So it should not be there yet at this point.
|
@H3AR7B3A7, thanks for taking the time and effort you've put into this pull request and helping us improve the tutorial by catching that small but rather important typo. I've checked, and it's good on my end. The styling should not be referenced here. Sorry for the confusion, but that information slipped through when the tutorial was being updated earlier. Going to merge this. Hope you have a great rest of the weekend. Stay safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the topic 'Addons' this component is tested by using the Controls Addon. At this point the overflow behavior with long strings is addressed by adding the styling and a visual regression test. Since this style is already added at the start of the course, someone following along the tutorial will not see the text overflow the component like in the examples. So it should not be there yet at this point.