Skip to content

Commit 4e598f3

Browse files
Elly Fong-JonesCommit Bot
authored andcommitted
flags: remove disable-pull-to-refresh-effect
This flag isn't supported any more. The corresponding switch (kDisablePullToRefreshEffect) is still used in the WebView code so it needs to stay. Bug: None Change-Id: I8ba201a974f0e237bd1f8fb9efd7abe3e62c95af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548358 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#646774}
1 parent bc0e704 commit 4e598f3

File tree

4 files changed

+0
-16
lines changed

4 files changed

+0
-16
lines changed

chrome/browser/about_flags.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1616,10 +1616,6 @@ const FeatureEntry kFeatureEntries[] = {
16161616
SINGLE_VALUE_TYPE(switches::kHostedAppQuitNotification)},
16171617
#endif // OS_MACOSX
16181618
#if defined(OS_ANDROID)
1619-
{"disable-pull-to-refresh-effect",
1620-
flag_descriptions::kPullToRefreshEffectName,
1621-
flag_descriptions::kPullToRefreshEffectDescription, kOsAndroid,
1622-
SINGLE_DISABLE_VALUE_TYPE(switches::kDisablePullToRefreshEffect)},
16231619
{"translate-force-trigger-on-english",
16241620
flag_descriptions::kTranslateForceTriggerOnEnglishName,
16251621
flag_descriptions::kTranslateForceTriggerOnEnglishDescription, kOsAndroid,

chrome/browser/flag-metadata.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -590,11 +590,6 @@
590590
// "owners": [ "your-team" ],
591591
"expiry_milestone": 76
592592
},
593-
{
594-
"name": "disable-pull-to-refresh-effect",
595-
// "owners": [ "your-team" ],
596-
"expiry_milestone": 76
597-
},
598593
{
599594
// See https://crbug.com/882238.
600595
"name": "disable-pushstate-throttle",

chrome/browser/flag_descriptions.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2542,10 +2542,6 @@ const char kProgressBarThrottleName[] = "Android progress update throttling.";
25422542
const char kProgressBarThrottleDescription[] =
25432543
"Limit the maximum progress update to make progress appear smoother.";
25442544

2545-
const char kPullToRefreshEffectName[] = "The pull-to-refresh effect";
2546-
const char kPullToRefreshEffectDescription[] =
2547-
"Page reloads triggered by vertically overscrolling content.";
2548-
25492545
const char kPwaImprovedSplashScreenName[] =
25502546
"Improved Splash Screen for standalone PWAs";
25512547
const char kPwaImprovedSplashScreenDescription[] =

chrome/browser/flag_descriptions.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1518,9 +1518,6 @@ extern const char kOffliningRecentPagesDescription[];
15181518
extern const char kProgressBarThrottleName[];
15191519
extern const char kProgressBarThrottleDescription[];
15201520

1521-
extern const char kPullToRefreshEffectName[];
1522-
extern const char kPullToRefreshEffectDescription[];
1523-
15241521
extern const char kPwaImprovedSplashScreenName[];
15251522
extern const char kPwaImprovedSplashScreenDescription[];
15261523
extern const char kPwaPersistentNotificationName[];

0 commit comments

Comments
 (0)