-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AUTHORS #112
Open
somilbansal11
wants to merge
1
commit into
chromium:main
Choose a base branch
from
somilbansal11:patch-3
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update AUTHORS #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Feb 18, 2022
Change-Id: Ia2724c2da9296b103d8332dac53b47f30da24c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3348343 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4758@{chromium#112} Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
@somilbansal11 hey i want to work on this can please guide me |
GrumpyOldTroll
pushed a commit
to GrumpyOldTroll/chromium
that referenced
this pull request
Mar 3, 2022
…shares. Specifically, stop showing (long) screenshot, STTS, QR code, LR when sharing created Reactions and Webnotes. (cherry picked from commit 739a72a) Fixed: 1290885 Change-Id: Iea02a487a6d86364cbde051637518779a6264036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3418660 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Guillaume Jenkins <gujen@google.com> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#964149} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3422607 Auto-Submit: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/branch-heads/4844@{chromium#112} Cr-Branched-From: 007241c-refs/heads/main@{#961656}
Damenly
pushed a commit
to openFyde/chromium
that referenced
this pull request
Mar 31, 2022
Change-Id: I112ed587d0a82afb49debe4ee25b836b64fe9eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3222785 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4664@{chromium#112} Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Mar 31, 2022
This CL will set the background for PedalSuggestionView. Before: https://screenshot.googleplex.com/kJroxwBbQBBefkJ After: https://screenshot.googleplex.com/8dZnQq6rMN4Wacd (cherry picked from commit 2b63eed) Bug: 1299999 Change-Id: I5f6a202220326adb49f9da56df65e392f0da8f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3482678 Reviewed-by: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#974368} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489746 Cr-Commit-Position: refs/branch-heads/4896@{#112} Cr-Branched-From: 1f63ff4-refs/heads/main@{#972766}
fujunwei
pushed a commit
to otcshare/chromium-src
that referenced
this pull request
May 4, 2022
Currently the "Open now" button doesn't update the state of the download (see screen record http://shortn/_4ImCfguWXO). Let DownloadCommands handles the press event from the "Open now" button. Since the button can be clicked while scanning is in progress (and it's not considered dangerous at this point), return early when executing the command when the download state is DOWNLOAD_DANGER_TYPE_ASYNC_SCANNING. (cherry picked from commit 9164d05) Bug: 1311867 Change-Id: I1b6a3631836b8f678d38662b79f304dbb300a30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3588795 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Reviewed-by: Rohit Bhatia <bhatiarohit@google.com> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#994455} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3601428 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/branch-heads/5005@{chromium#112} Cr-Branched-From: 5b4d945-refs/heads/main@{#992738}
ashie
pushed a commit
to clear-code/chromium
that referenced
this pull request
May 10, 2022
kMICEWebSignIn flag is used for the sign-in bottom sheet. kMobileIdentityConsistency is required to enable kMICEWebSignIn. (cherry picked from commit 5a31acc) Fixed: 1213067 Change-Id: I6e37beac477be0c20abfcefcacabcd44e0e61cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2917021 Commit-Queue: Jérôme <jlebel@chromium.org> Auto-Submit: Jérôme <jlebel@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#886537} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2919694 Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/branch-heads/4515@{chromium#112} Cr-Branched-From: 488fc70-refs/heads/master@{#885287}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 4, 2022
BUG=b:201111413 TEST=build (cherry picked from commit 6886095) Change-Id: Ie9c42a40d6640a1d8799fc56b807119aaba4c75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3534221 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Original-Commit-Position: refs/heads/main@{#984128} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546299 Cr-Commit-Position: refs/branch-heads/4951@{chromium#112} Cr-Branched-From: 27de622-refs/heads/main@{#982481}
pkviet
pushed a commit
to pkviet/chromium
that referenced
this pull request
Jun 6, 2022
The flag local history zero suggest allow the use of local history as search suggestions. They are of type SEARCH_HISTORY. FYI, search suggestions from user history are of type SEARCH_SUGGEST_PERSONALIZED. This CL adds SEARCH_HISTORY to the list of append-able suggestion type. (cherry picked from commit 0e82982) Bug: 1326413 Change-Id: Id1d884b77d1cb80bc48486f922c6572ec8172834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644572 Commit-Queue: Christian Xu <christianxu@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1004167} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653833 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Christian Xu <christianxu@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{chromium#112} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
aarongable
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
darinwf
pushed a commit
to neevaco/chromium
that referenced
this pull request
Aug 10, 2022
(cherry picked from commit 4df56fc) Bug: 1335010 Change-Id: Id9b7811e28fa2de48d091b1590c21d4503bdca2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3710315 Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/branch-heads/5112@{chromium#112} Cr-Branched-From: b13d3fe-refs/heads/main@{#1012729}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Aug 31, 2022
…rk-105.0.5190.0-r1 to 105-5187.0-1658744978-benchmark-105.0.5195.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4ed16389c0e8d69cd73800f4ba28edad2dbd9ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3792272 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5195@{#112} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Sep 29, 2022
Also fixes issue where feed header would lose stickiness when changing back and forth (which was caused by crrev.com/c/3834792) (cherry picked from commit 5ab670a) Bug: 1354283 Change-Id: I298798ee15a20b33881e46dfd4466f563f044d2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3838686 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Arcaro <adamta@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1036903} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846192 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Adam Arcaro <adamta@google.com> Cr-Commit-Position: refs/branch-heads/5249@{#112} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd
referenced
this pull request
in blueboxd/chromium-legacy
Oct 28, 2022
This reverts commit bbe4eae. Reason for revert: Tests are failing https://crbug.com/1364541 Original change's description: > Implementation and tests for SevenZipReader > > This CL adds implementation and tests for the SevenZipReader. Adding a > new test target adds significant linking costs on all the builders, so > tests are located in //third_party/lzma_sdk, but run as part of //chrome/test:unit_tests > > Implementation is heavily based on > //chrome/installer/util/lzma_util.cc, but this code should run behind > a feature flag, so we need both copies in the short term. > > Bug: 1355567 > Change-Id: Id1a66bc2ad122d8b475fad0c616df6d1ffdee532 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3888221 > Reviewed-by: thefrog <thefrog@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1047629} (cherry picked from commit fe4f3f2) Bug: 1355567, 1364541 Change-Id: Ic6462548144eb17426c5fc69ca21ca21d16e76b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899799 Reviewed-by: John Chen <johnchen@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by: thefrog <thefrog@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Daniel Rubery <drubery@chromium.org> Owners-Override: Hazem Ashmawy <hazems@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1048037} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914866 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/branch-heads/5304@{#112} Cr-Branched-From: 5d7b1fc-refs/heads/main@{#1047731}
MaoHan001
pushed a commit
to riscv-android-src/chromium
that referenced
this pull request
Jan 17, 2023
…dyLoader There was a crash in GetEncodingMap() which is in third_party/ced. It looks like this map is not thread safe, so may have issues when being initialized from two different threads. This is a speculative fix to initialize on the main thread, and if this works I can look into making the map thread safe. (cherry picked from commit d988106) Bug: 1384221 Change-Id: I1bb8b7d7b285231781624fe1fe856ddf016128be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4026826 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1071756} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4032691 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/branch-heads/5414@{chromium#112} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
wwwppp0801
pushed a commit
to wwwppp0801/chromium
that referenced
this pull request
Feb 13, 2023
More devices require letterboxing to render mirroring frames correctly. Disable the feature for M110 until a better strategy for rolling out this deprecation can be determined. (cherry picked from commit 526cf4c) Bug: 1363512,1400691 Change-Id: I5fb82c7ea8cbacd31c464022954f6d7ef9d764ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112407 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: Benjamin Zielinski <bzielinski@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1084096} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134664 Reviewed-by: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/branch-heads/5481@{chromium#112} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
chirayudesai
pushed a commit
to chirayudesai/chromium
that referenced
this pull request
Mar 7, 2023
All of the ExecuteScript* methods can finish with a script execution error, which is why the fallback values are specified. Errors are logged by the callers. NOTREACHED() shouldn't be used there. (cherry picked from commit aa8aef2) Bug: 1410177 Change-Id: Ic594d42a70268b9a0fdf5f1481120083dbfac06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4201209 Commit-Queue: Basia Zimirska <basiaz@google.com> Reviewed-by: Anthony Cui <cuianthony@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1098799} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215254 Cr-Commit-Position: refs/branch-heads/5563@{chromium#112} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
calyxos-gerrit
pushed a commit
to CalyxOS/chromium
that referenced
this pull request
Mar 31, 2023
StorageKeys constructed for pages will now query the main frame's RuntimeFeatureState to determine if they should support third-party storage partitioning or not. This only affects StorageKeys created in contexts usable by Storage APIs. StorageKeys created outside those contexts will continue to be constructed based on net::features::kThirdPartyStoragePartitioning. This change is made under the assumption that RuntimeFeatureState is only used to disable partitioning when it's otherwise globally enabled. If the inverse becomes desired (enabling otherwise disabled partitioning) then this change will need to be revised. The behavior in different frame and navigation situations is outlined in https://docs.google.com/document/d/1FqZ3mRQeHlf9yWT6EJKBnJzXVqFGpmuD9PnRtzAJ1gY/ (Google only) (cherry picked from commit 4e4bd9b) Bug: 1412576, 1199077, 1377000 Change-Id: I74d878c36ba966ec565de6b3d73782a1ec6ae34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4219563 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1110520} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4299752 Commit-Queue: Kyra Seevers <kyraseevers@chromium.org> Cr-Commit-Position: refs/branch-heads/5615@{chromium#112} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Apr 20, 2023
Not really sure what the condition means, but it according to the bug report, it happens for some users in a brand when accepting an omnibox suggestion in a brand new window (tried but could not repro). R=lgrey@chromium.org R=benjamin.beaudry@microsoft.com (cherry picked from commit 7f429cd) (cherry picked from commit 526794e) Bug: 1425682 Change-Id: Iea5a28a9b0bcba3f268d09ca147e1da35fd34f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370433 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/main@{#1121959} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382229 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Original-Commit-Position: refs/branch-heads/5672@{chromium#112} Cr-Original-Branched-From: 5f2a724-refs/heads/main@{#1121455} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4415124 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/branch-heads/5615@{#1220} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
herocharge
pushed a commit
to vwvw/chromium
that referenced
this pull request
May 24, 2023
TBR=lakpamarthy@chromium.org Change-Id: Ia759455ccd0b2df20297d659578842a79c916109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2733758 Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/4430@{chromium#112} Cr-Branched-From: e5ce7dc-refs/heads/master@{#857950}
l0hn
pushed a commit
to l0hn/chromium_test
that referenced
this pull request
Jun 9, 2023
These features are causing some regressions. While I investigate and hopefully fix them, I'd like to disable the features. (cherry picked from commit a928903) Fixed: 1435358, 1440029, 1439802 Change-Id: I90a868ea5a3b5cde218202598d22e0a0df2dbe3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481636 Reviewed-by: Robert Flack <flackr@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1136777} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496699 Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{chromium#112} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
msizanoen1
pushed a commit
to qtmlabs/chromium
that referenced
this pull request
Jun 27, 2023
(cherry picked from commit 70e65d5) Bug: chromium:1309653 Change-Id: I20b83855fa3daf99515030b7b88ce863fe366050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4632518 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Auto-Submit: Johannes Kron <kron@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1160808} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4647648 Cr-Commit-Position: refs/branch-heads/5845@{chromium#112} Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
aetota61
pushed a commit
to monkbrowser/monk-browser
that referenced
this pull request
Aug 2, 2023
Prior to this CL, any origin with a trailing dot in the host name would fail the origin-validity check in ChildProcessSecurityPolicyImpl:: AddOriginIsolationStateForBrowsingInstance() during attempts to opt-in or out of origin isolation. This CL corrects this, and adds a test. (cherry picked from commit d8d31f0) Bug: 1446661 Change-Id: Iba17968adcb7d3c3af24b605f662318f5c5dc25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4544436 Commit-Queue: James Maclean <wjmaclean@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1149853} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4569065 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/branch-heads/5790@{chromium#112} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
trflynn89
pushed a commit
to RebelBrowser/rebel
that referenced
this pull request
Oct 26, 2023
See crbug.com/1479809 for more details. (cherry picked from commit 242766f) Bug: 1479809 Change-Id: Ic8f83706709d9a47f628a0c9c521b0bb7d6e8c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4845792 Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1194004} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4853350 Cr-Commit-Position: refs/branch-heads/5993@{chromium#112} Cr-Branched-From: 5113507-refs/heads/main@{#1192594}
vuzix-jeff
pushed a commit
to Vuzix/chromium
that referenced
this pull request
Nov 3, 2023
Commits rolled: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/39d79e523913..ff3fbdb2d136 Generated by: go/bbid/8767997704511820369 Change-Id: Ib6d2dab4459eb72d7c6a07b62905ed1c8dbaefc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916979 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6045@{chromium#112} Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
Aikoyori
referenced
this pull request
in Pissandshittium/pissandshittium
Dec 8, 2023
(cherry picked from commit a63d155) Bug: 1497753 Change-Id: I524da48e8e637a25d4b6829b7eb79b673940d37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987358 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Nicola Tommasi <tommasin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1217436} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5002231 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6099@{#112} Cr-Branched-From: e6ee450-refs/heads/main@{#1217362}
aarongable
pushed a commit
that referenced
this pull request
Jan 6, 2024
Roll Chrome Win64 PGO profile from chrome-win64-6167-1701986234-2041944939484636fa259b43fff675573b609615.profdata to chrome-win64-6167-1702015141-625a8a1745906597ce26899135be66c41062514b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m121.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I48e30af4743d47b37acad9e24f10a2a4a72b0218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5101665 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6167@{#112} Cr-Branched-From: 222e786-refs/heads/main@{#1233107}
aarongable
pushed a commit
that referenced
this pull request
Jan 26, 2024
Change-Id: Ib07cdcd5ca9e162bf23e89f6140298fb1c6db3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5238230 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6261@{#112} Cr-Branched-From: 9755d9d-refs/heads/main@{#1250580}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
Feb 21, 2024
New rules: - Always divider - Header same color as background - On iOS 15, when the view scrolls behind the nav bar, the nav bar header becomes semi-translucent. This is a nice effect. (cherry picked from commit 8d27a13) Bug: 1242390 Change-Id: I30f727427648ba6e637ba34a9c22d65e56e82e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3151836 Auto-Submit: Robbie Gibson <rkgibson@google.com> Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: David Jean <djean@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#920145} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159529 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/branch-heads/4638@{chromium#112} Cr-Branched-From: 159257c-refs/heads/main@{#920003}
aarongable
pushed a commit
that referenced
this pull request
Feb 23, 2024
…tImmediately metrics After analyzing one week's worth of canary data for these two trace events, the performance looks pretty similar between the two. I think it’s safe to conclude that we are unlikely to see major differences in the trace events between the two. Combine the two trace events so that we can have a more direct before and after comparison for the impact of layout work since DeprecatedLayoutImmediately will be removed. (cherry picked from commit 96505c6) Bug: 41492224 Change-Id: I2dce9f58b6a5a5497413ece8d8e51779b8667a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5309765 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1263041} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322159 Auto-Submit: Elaine Chien <elainechien@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/branch-heads/6312@{#112} Cr-Branched-From: 6711dcd-refs/heads/main@{#1262506}
NaaeemMalik
pushed a commit
to SoftwarePrince/Egon-Chromium
that referenced
this pull request
Mar 22, 2024
Uploaded by https://ci.chromium.org/b/8772830691833866481 Change-Id: I24e8f0a946db8252d9afd57b8695f42674a9313e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4779154 Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5938@{chromium#112} Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
aarongable
pushed a commit
that referenced
this pull request
Mar 22, 2024
Roll Chrome Mac PGO profile from chrome-mac-6367-1711017151-946973d65dbdbd5548fe96c9714f63c1b6b99303-0fec11f3b3c1b670580a2e1b125c0c20c81aa378.profdata to chrome-mac-6367-1711077473-3cec1faeec3fdf630c22ce1367c96e1bcce43785-a07f2b73f7abd27e90bbfc1cb75764bea0867242.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium-beta Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium beta branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome-m124.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2bbbd3b00f4ba63e5cf56c5837117491ba28a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5386668 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6367@{#112} Cr-Branched-From: d158c6d-refs/heads/main@{#1274542}
aarongable
pushed a commit
that referenced
this pull request
Apr 19, 2024
…125.0.6422.6-r1 to 125-6411.0-1713176715-benchmark-125.0.6422.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium-beta Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: mobiletc-prebuild@google.com Change-Id: I11b53875fe16beedd66cc4e61f959c230a128d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5467667 Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6422@{#112} Cr-Branched-From: 9012208-refs/heads/main@{#1287751}
aarongable
pushed a commit
that referenced
this pull request
May 17, 2024
This CL will update lacros version in //chrome/LACROS_QA_QUALIFIED_VERSION. This file will be used in Upreving the RootFS-Lacros in the CROS image. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-qa-qualified-tracking-roller Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I845956c3023ff2faacdc2edcb1366af17ef7a7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546997 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com <lacros-tracking-roller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/6478@{#112} Cr-Branched-From: e6143ac-refs/heads/main@{#1300313}
consp1racy
pushed a commit
to signageos/chromium-chromium
that referenced
this pull request
May 24, 2024
This CL adds an animation that starts a scaling animation once a 300ms touch press gesture has been recognized in the browser. The start of this animation corresponds with when the user is able to start a tab dragging session. The tab grows until it reaches the size of a draggable tab. The scaling effect will be removed in the following circumstances: - If the user releases their finger without dragging or triggering a context menu. - If the user triggers and then closes the context menu. - If the user starts dragging a tab (the enlarged tab is replaced with the scaled drag image). This animation behavior aligns with similar behavior for AppListItemViews on the ChromeOS app shelf. Demo below. https://drive.google.com/file/d/1ZU_TitPhn9NN96w6UnekXAtdauEyteld/view?usp=sharing (cherry picked from commit 00bbb16) Bug: 1195502 Change-Id: If575a92afda49e2dcd28fa0e4d0259207b9c7f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2811639 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Collin Baker <collinbaker@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Reviewed-by: Yuheng Huang <yuhengh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#870784} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826706 Cr-Commit-Position: refs/branch-heads/4472@{chromium#112} Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.